Skip to content

Error when two packages have same prefix #107

@utkarshk384

Description

@utkarshk384

The issue here is that I have two packages named as @UI/theme and @UI/theme-utils and when I try to use any scripts with @UI/theme the following error is thrown to me:

☔️ error an identifier must only match a single package but "theme" matches the following packages: 
☔️ error @UI/theme
☔️ error @UI/theme-utils

Upon looking at the source code I found the following lines of code that could possibly be causing the issue:

const matchingPackages = packages.filter(pkg => {
return (
pkg.packageJson.name.includes(args[0]) ||
path.relative(root.dir, pkg.dir).includes(args[0])
);
});

This code snippet lies within the runCmd function here.

I suppose that arg[0] might be the package that is calling the CLI command. So, for example, I am currently calling the CLI command for the theme package therefore arg[0] should be @UI/theme.

With that out of the way now I think includes is matching all the packages that have that same name, therefore, causing the issue here. I'll try to make a pull request to fix the issue.

Edit: args[0] doesn't equal to @UI/theme but just theme. I had overlooked some parts of the code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions