Skip to content

Markings report fails in non-monorepo style repos #33

@majgaard

Description

@majgaard

The way the code below is written causes markings reports to fail for any markings in files which belong to the root package.

function getPackageFromFilename(
repoRoot: string,
filename: string,
packagesByDirectory: Map<string, Package>
) {
let currentDir = nodePath.dirname(filename);
while (currentDir !== repoRoot) {
let maybeCurrentPackage = packagesByDirectory.get(currentDir);
if (maybeCurrentPackage !== undefined) {
return maybeCurrentPackage;
}
currentDir = nodePath.dirname(currentDir);
}
throw new Error(`could not find package from ${JSON.stringify(filename)}`);
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions