refactor(app): remove position getters/setters and streamline player info handling

Author: ThornWalli

packages/app/lib/classes/Player.ts

@@ -54,22 +54,6 @@ export default class Player {
     console.log('Player unit set:', this.unit.name);
   }
 
-  get position() {
-    if (this.unit) {
-      return this.unit.root.position;
-    } else {
-      throw new Error('Player unit is not set, cannot get position');
-    }
-  }
-
-  set position(position: Vector3) {
-    if (this.unit) {
-      this.unit.setPosition(position);
-    } else {
-      throw new Error('Player unit is not set, cannot update position');
-    }
-  }
-
   moveTo(position: Vector3) {
     if (this.unit) {
       this.unit.modules.movement.moveTo(position);

packages/app/lib/classes/appModule/Multiplayer.ts

@@ -56,7 +56,7 @@ interface PlayerInfo {
   peerId: string;
   name: string;
   color: PLAYER_COLOR;
-  position?: [number, number, number];
+  position: [number, number, number];
 }
 export default class MultiplayerAppModule extends AppModule<State> {
   static override TYPE = 'multiplayer';
@@ -253,7 +253,7 @@ export default class MultiplayerAppModule extends AppModule<State> {
       //   userId: userCredential.user.uid
       // }
     });
-    console.log(player);
+
     return player;
   }
 
@@ -307,6 +307,7 @@ export default class MultiplayerAppModule extends AppModule<State> {
     const room = this.state.room;
 
     // #region player moveTo action
+
     const [setMoveTo, getMoveTo] =
       room.makeAction<MoveToPayload>('playerMoveTo');
 
@@ -321,7 +322,7 @@ export default class MultiplayerAppModule extends AppModule<State> {
     // #region send message action
 
     const [sendMessage, getMessage] = room.makeAction<Message & DataPayload>(
-      'plyMessage'
+      'messaging'
     );
 
     getMessage((data, peerId) =>
@@ -341,13 +342,7 @@ export default class MultiplayerAppModule extends AppModule<State> {
     getPlayerInfo((data, peerId) => {
       const player = this.players.get(peerId);
       if (player) {
-        debugger;
-        player.name = data.name;
-        player.setColor(data.color);
-        // übernehme position
-        if (data.position) {
-          player.unit?.setPosition(new Vector3().fromArray(data.position));
-        }
+        this.setPlayerInfo(player, data);
       }
     });
 
@@ -356,6 +351,14 @@ export default class MultiplayerAppModule extends AppModule<State> {
     // #endregion
   }
 
+  setPlayerInfo(player: Player, info: PlayerInfo) {
+    player.name = info.name;
+    player.setColor(info.color);
+    // set position if available
+    const position = new Vector3().fromArray(info.position);
+    player.unit?.setPosition(position);
+  }
+
   sendMessage(message: Omit<Message, 'timestamp' | 'playerId'>) {
     const player = this.app.modules.player.getCurrentPlayer();
     if (!player) {