Skip to content

Commit e0e1fe0

Browse files
committed
[Minor][FLINK-39168][cdc-connector-mysql] Cache split.splitId() result in a local variable to avoid calling the method twice per iteration: (apache#4288)
Co-authored-by: Thorne <syyfffy@163.com>
1 parent 6adda1f commit e0e1fe0

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,11 +400,12 @@ public List<FinishedSnapshotSplitInfo> getFinishedSplitInfos() {
400400
new ArrayList<>(assignedSplits.values());
401401
List<FinishedSnapshotSplitInfo> finishedSnapshotSplitInfos = new ArrayList<>();
402402
for (MySqlSchemalessSnapshotSplit split : assignedSnapshotSplit) {
403-
BinlogOffset binlogOffset = splitFinishedOffsets.get(split.splitId());
403+
String splitId = split.splitId();
404+
BinlogOffset binlogOffset = splitFinishedOffsets.get(splitId);
404405
finishedSnapshotSplitInfos.add(
405406
new FinishedSnapshotSplitInfo(
406407
split.getTableId(),
407-
split.splitId(),
408+
splitId,
408409
split.getSplitStart(),
409410
split.getSplitEnd(),
410411
binlogOffset));

0 commit comments

Comments
 (0)