Skip to content

Commit e9041b0

Browse files
committed
fix : Update test files to use UUID instead of Long for postDTO
1 parent 535c8df commit e9041b0

3 files changed

Lines changed: 21 additions & 15 deletions

File tree

hexfeed-backend/src/test/java/com/hexfeed/controller/FeedControllerSimpleTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import java.util.Collections;
2727
import java.util.List;
2828
import java.util.Map;
29+
import java.util.UUID;
2930

3031
import static org.junit.jupiter.api.Assertions.*;
3132
import static org.mockito.ArgumentMatchers.*;
@@ -330,9 +331,11 @@ private FeedResponse createSampleFeedResponse() {
330331

331332
private PostDTO createSamplePost(Long id, String content) {
332333
PostDTO post = new PostDTO();
333-
post.setId(id);
334+
UUID postId = UUID.randomUUID();
335+
UUID userId = UUID.randomUUID();
336+
post.setPostId(postId);
334337
post.setContent(content);
335-
post.setUserId(id);
338+
post.setUserId(userId);
336339
post.setTimestamp(LocalDateTime.now());
337340
post.setType("TEXT");
338341
post.setVisibility("public");

hexfeed-backend/src/test/java/com/hexfeed/model/dto/FeedDTOsTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import java.util.HashMap;
1414
import java.util.List;
1515
import java.util.Set;
16+
import java.util.UUID;
1617

1718
import static org.junit.jupiter.api.Assertions.*;
1819

@@ -78,8 +79,10 @@ void testFeedRequestValidation() {
7879
@DisplayName("PostDTO should populate all fields correctly")
7980
void testPostDTOPopulation() {
8081
PostDTO post = new PostDTO();
81-
post.setId(1L);
82-
post.setUserId(123L);
82+
UUID postId = UUID.randomUUID();
83+
UUID userId = UUID.randomUUID();
84+
post.setPostId(postId);
85+
post.setUserId(userId);
8386
post.setUsername("testuser");
8487
post.setDisplayName("Test User");
8588
post.setContent("This is a test post");
@@ -93,8 +96,8 @@ void testPostDTOPopulation() {
9396
post.setVisibility("PUBLIC");
9497

9598
// Test basic fields
96-
assertEquals(1L, post.getId());
97-
assertEquals(123L, post.getUserId());
99+
assertEquals(postId, post.getPostId());
100+
assertEquals(userId, post.getUserId());
98101
assertEquals("testuser", post.getUsername());
99102
assertEquals("This is a test post", post.getContent());
100103
assertEquals("872830828ffffff", post.getHexId());
@@ -170,13 +173,13 @@ void testPaginationInfoDerivedFields() {
170173
void testFeedResponseBuilder() {
171174
// Create sample posts
172175
PostDTO post1 = new PostDTO();
173-
post1.setId(1L);
176+
post1.setPostId(UUID.randomUUID());
174177
post1.setUsername("user1");
175178
post1.setContent("First post");
176179
post1.setHexId("872830828ffffff");
177180

178181
PostDTO post2 = new PostDTO();
179-
post2.setId(2L);
182+
post2.setPostId(UUID.randomUUID());
180183
post2.setUsername("user2");
181184
post2.setContent("Second post");
182185
post2.setHexId("872830829ffffff");

hexfeed-backend/src/test/java/com/hexfeed/service/FeedAggregationServiceIntegrationTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -281,16 +281,16 @@ void shouldVerifyPaginationWorks() {
281281
assertTrue(page2Response.getPagination().isHasPrevious(), "Page 2 should have previous");
282282

283283
// Verify different posts on different pages
284-
Set<Long> page1PostIds = page1Response.getPosts().stream()
285-
.map(PostDTO::getId)
284+
Set<UUID> page1PostIds = page1Response.getPosts().stream()
285+
.map(PostDTO::getPostId)
286286
.collect(Collectors.toSet());
287287

288-
Set<Long> page2PostIds = page2Response.getPosts().stream()
289-
.map(PostDTO::getId)
288+
Set<UUID> page2PostIds = page2Response.getPosts().stream()
289+
.map(PostDTO::getPostId)
290290
.collect(Collectors.toSet());
291291

292292
// No overlap between pages (different posts)
293-
Set<Long> intersection = new HashSet<>(page1PostIds);
293+
Set<UUID> intersection = new HashSet<>(page1PostIds);
294294
intersection.retainAll(page2PostIds);
295295
assertTrue(intersection.isEmpty(), "Pages should have different posts (no overlap)");
296296

@@ -343,8 +343,8 @@ void shouldTestCacheHitMissScenarios() {
343343
assertEquals(response1.getPosts().size(), response2.getPosts().size(), "Both responses should have same number of posts");
344344

345345
// Verify post IDs are the same (same data)
346-
List<Long> postIds1 = response1.getPosts().stream().map(PostDTO::getId).sorted().collect(Collectors.toList());
347-
List<Long> postIds2 = response2.getPosts().stream().map(PostDTO::getId).sorted().collect(Collectors.toList());
346+
List<UUID> postIds1 = response1.getPosts().stream().map(PostDTO::getPostId).sorted(UUID::compareTo).collect(Collectors.toList());
347+
List<UUID> postIds2 = response2.getPosts().stream().map(PostDTO::getPostId).sorted(UUID::compareTo).collect(Collectors.toList());
348348
assertEquals(postIds1, postIds2, "Both responses should have the same posts");
349349

350350
// Test cache performance (second call should be faster or similar)

0 commit comments

Comments
 (0)