Skip to content

Commit 8309d5e

Browse files
authored
Fix logger error fields not clearing in the Subscriber consume method (#49)
1 parent 33558e7 commit 8309d5e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

pkg/sql/subscriber.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,13 +248,14 @@ func (s *Subscriber) consume(ctx context.Context, topic string, out chan *messag
248248
noMsg, err := s.query(ctx, topic, out, logger)
249249
backoff := s.config.BackoffManager.HandleError(logger, noMsg, err)
250250
if backoff != 0 {
251-
if err != nil {
252-
logger = logger.With(watermill.LogFields{"err": err.Error()})
253-
}
254-
logger.Trace("Backing off querying", watermill.LogFields{
251+
logFields := watermill.LogFields{
255252
"wait_time": backoff,
256253
"no_msg": noMsg,
257-
})
254+
}
255+
if err != nil {
256+
logFields.Add(watermill.LogFields{"err": err.Error()})
257+
}
258+
logger.Trace("Backing off querying", logFields)
258259
}
259260
sleepTime = backoff
260261
}

0 commit comments

Comments
 (0)