Skip to content

Commit ca5511e

Browse files
committed
code review
1 parent d29a1fa commit ca5511e

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/Ocelot/Configuration/Creator/AggregatesCreator.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ namespace Ocelot.Configuration.Creator
55
{
66
public class AggregatesCreator : IAggregatesCreator
77
{
8-
private readonly IUpstreamTemplatePatternCreator _creator;
8+
private readonly IUpstreamTemplatePatternCreator _creator;
99
private readonly IUpstreamHeaderTemplatePatternCreator _headerCreator;
1010

1111
public AggregatesCreator(IUpstreamTemplatePatternCreator creator, IUpstreamHeaderTemplatePatternCreator headerCreator)
1212
{
13-
_creator = creator;
13+
_creator = creator;
1414
_headerCreator = headerCreator;
1515
}
1616

@@ -26,24 +26,24 @@ private Route SetUpAggregateRoute(IEnumerable<Route> routes, FileAggregateRoute
2626
{
2727
if (!aggregateRoute.UpstreamHttpMethod.Any())
2828
{
29-
// Default Method to Get for standard use case
30-
aggregateRoute.UpstreamHttpMethod.Add("Get");
29+
// Default method to Get for standard use case
30+
aggregateRoute.UpstreamHttpMethod.Add(HttpMethod.Get.ToString());
3131
}
3232

3333
var applicableRoutes = new List<DownstreamRoute>();
3434
var allRoutes = routes.SelectMany(x => x.DownstreamRoute);
3535
var downstreamRoutes = aggregateRoute.RouteKeys.Select(routeKey => allRoutes.FirstOrDefault(q => q.Key == routeKey));
3636
foreach (var downstreamRoute in downstreamRoutes)
37-
{
37+
{
3838
if (downstreamRoute == null)
39-
{
40-
return null;
41-
}
42-
39+
{
40+
return null;
41+
}
42+
4343
applicableRoutes.Add(downstreamRoute);
4444
}
4545

46-
var upstreamTemplatePattern = _creator.Create(aggregateRoute);
46+
var upstreamTemplatePattern = _creator.Create(aggregateRoute);
4747
var upstreamHeaderTemplates = _headerCreator.Create(aggregateRoute);
4848

4949
var route = new RouteBuilder()
@@ -52,7 +52,7 @@ private Route SetUpAggregateRoute(IEnumerable<Route> routes, FileAggregateRoute
5252
.WithDownstreamRoutes(applicableRoutes)
5353
.WithAggregateRouteConfig(aggregateRoute.RouteKeysConfig)
5454
.WithUpstreamHost(aggregateRoute.UpstreamHost)
55-
.WithAggregator(aggregateRoute.Aggregator)
55+
.WithAggregator(aggregateRoute.Aggregator)
5656
.WithUpstreamHeaders(upstreamHeaderTemplates)
5757
.Build();
5858

0 commit comments

Comments
 (0)