test: updates test cases for funder.json endpoint

Author: jwilson232

registry/tests/mock_simple_salesforce/threesixty.py

@@ -93,6 +93,13 @@ class MockSimpleSalesforce360Giving(MockSimpleSalesforce):
         },
     ]
 
+    FUNDER_STATUSES = [
+        "Funder in GrantNav",
+        "360Giving Publisher",
+        "Something else",
+        None,
+    ]
+
     def __init__(self, **kwargs) -> None:
         """Initialise a Mock SimpleSalesforce object setup to represent the 360 Registry
 
@@ -110,6 +117,17 @@ def __init__(self, **kwargs) -> None:
                 "Authorised_Domain",
                 "Self_registration_enabled",
                 "Last_published_date",
+                "Publisher_Prefix_Combined",
+                "Publisher_Prefix",
+                "Org_Case_Safe_ID",
+                "X360Giving_Publisher",
+                "Sectors",
+                "Sector_Organisation_type",
+                "Sector_Organisation_sub_type",
+                "First_Published_Date",
+                "Latest_Published_Date",
+                "Update_schedule",
+                "Update_Method",
             ]
         )
 
@@ -181,21 +199,31 @@ def _generate_accounts(self, num: int, num_with_no_prefix: int) -> None:
                 else None
             )
             base_url = random_invalid_base_url(self.rnd)
+            prefix = f"360G-CT{index+1}" if index > (num_with_no_prefix - 1) else None
             self.create_record(
                 "Account",
                 {
                     "Name": f"Charitable Trust {index+1}",
                     "Logo__c": logo,
                     "Website": base_url + "index.html",
-                    "prefix__c": (
-                        f"360G-CT{index+1}"
-                        if index > (num_with_no_prefix - 1)
-                        else None
-                    ),
+                    "prefix__c": prefix,
                     "Org_Identifier__c": random_orgid(self.rnd),
                     "Authorised_Domain__c": base_url,
                     "Self_registration_enabled__c": False,
                     "Last_published_date__c": datetime(1900, 1, 1, 0, 0, 0),
+                    "Publisher_Prefix_Combined__c": prefix,
+                    "Publisher_Prefix__c": prefix,
+                    "Org_Case_Safe_ID__c": f"case-safe-{index+1}",
+                    "X360Giving_Publisher__c": self.FUNDER_STATUSES[
+                        index % len(self.FUNDER_STATUSES)
+                    ],
+                    "Sectors__c": "Health",
+                    "Sector_Organisation_type__c": "Charity",
+                    "Sector_Organisation_sub_type__c": "Grant-maker",
+                    "First_Published_Date__c": datetime(2017, 1, 1, 0, 0, 0),
+                    "Latest_Published_Date__c": datetime(1900, 1, 1, 0, 0, 0),
+                    "Update_schedule__c": "Quarterly",
+                    "Update_Method__c": "API",
                 },
             )
 

registry/tests/test_views.py

@@ -38,6 +38,7 @@ def test_views(self):
             reverse_lazy("ui:index"),
             reverse_lazy("data"),
             reverse_lazy("publishers"),
+            reverse_lazy("funders"),
         ]
 
         for url in urls:
@@ -65,3 +66,47 @@ def test_json_length(self):
             "distribution",
         ]:
             self.assertIn(key, data[0].keys())
+
+    def test_funders_json(self):
+        response = self.client.get(reverse_lazy("funders"))
+        data = response.json()
+
+        cur = self.mock_sf.con.cursor()
+        expected_ids = [
+            row[0]
+            for row in cur.execute(
+                "SELECT Id FROM Account WHERE "
+                "X360Giving_Publisher__c = 'Funder in GrantNav' "
+                "OR X360Giving_Publisher__c = '360Giving Publisher';"
+            ).fetchall()
+        ]
+
+        self.assertEqual(sorted(data.keys()), sorted(expected_ids))
+
+        for account_id, funder in data.items():
+            self.assertEqual(funder["id"], account_id)
+            self.assertIn(
+                funder["x360GivingPublisher"],
+                ["Funder in GrantNav", "360Giving Publisher"],
+            )
+            for key in ["name", "prefix", "orgIdentifier"]:
+                self.assertIn(key, funder.keys())
+
+    def test_funders_json_excludes_non_funders(self):
+        response = self.client.get(reverse_lazy("funders"))
+        data = response.json()
+
+        cur = self.mock_sf.con.cursor()
+        excluded_ids = [
+            row[0]
+            for row in cur.execute(
+                "SELECT Id FROM Account WHERE "
+                "X360Giving_Publisher__c IS NULL "
+                "OR (X360Giving_Publisher__c != 'Funder in GrantNav' "
+                "AND X360Giving_Publisher__c != '360Giving Publisher');"
+            ).fetchall()
+        ]
+
+        self.assertTrue(len(excluded_ids) > 0)
+        for account_id in excluded_ids:
+            self.assertNotIn(account_id, data.keys())