Missing expected functions not being flagged as failure

[wosym]

Calling a mocked function that does not have an _Expect call in the Unit tests (or calling the mocked function more than _Expect calls were made) results in an error "Called more times than expected". This makes sense.
However, when making less calls to the mocked function than there are _Expect calls in the Unit test does not result in any error? This surprises me.

From what I understand from digging online, and reading pages such as this one, that one and this one, there is a _Verify function that needs to be called in some cases, in order for the call-counters to be compared.

We can find this function in the generated mock files, yes. But:

1. This _Verify function isn't mentioned anywhere in the docs.
2. I can't recall ever having used this function when using CMock in the past.

Could this be clarified? Is this a missing element in the docs? Is it a bug in CMock? Or... are we simply doing something wrong still?

[rstahn]

I stumbled about this behavior in the past too, but IMHO it is not a bug in CMock. AFAIK this is only an issue, when you are using CMock and Unity without Ceedling. If you use Ceedling it will generate all necessary calls to the _Verify functions for you.

Since I am using CMock without Ceedling, I have already looked into ways to enforce the calls of the _Verify functions - but I have not found a good solution yet. For now it's a matter of routine and discipline to add a _Verify for every _Init of a mock. Maybe the use case "CMock without Ceedling" can indeed be clarified in the docs. I will take a look, when I find some time.

[mvandervoord]

Hi @wosym -- I had thought that was added to the docs literally years ago and have never given it another thought. Poking around now, I'm not seeing it in the main docs... just the website. That's an oversight I'll be sure to correct (I'm flagging this issue as a doc issue and leaving it open to remind us to fix it).

Most people that use CMock are either using Ceedling, or they're using the test runner generator that comes with Unity. Either of these tools automatically handle the Verify functions.

To clarify. If you're going to create your own test runners (ie, you're going to create the main function and/or functions which calls the tests) AND you're using mocks, you should ALWAYS call each MockBlah_Init() before each test and call each MockBlah_Verify after each test.

[JackNWhite]

#518