Refactor error handling and code structure in webhook.js

- Improved error handling for fetching knowledge base content.
- Streamlined the logic for checking namespace and handling different content types.
- Removed redundant code and enhanced readability.

Author: JohnnyUB

routes/webhook.js

@@ -12,7 +12,7 @@ var ObjectId = require('mongoose').Types.ObjectId;
 const default_embedding = require('../config/kb/embedding');
 
 const port = process.env.PORT || '3000';
-let TILEBOT_ENDPOINT = "http://localhost:" + port + "/modules/tilebot/";;
+let TILEBOT_ENDPOINT = "http://localhost:" + port + "/modules/tilebot/";
 if (process.env.TILEBOT_ENDPOINT) {
     TILEBOT_ENDPOINT = process.env.TILEBOT_ENDPOINT + "/"
 }
@@ -69,18 +69,12 @@ router.post('/kb/reindex', async (req, res) => {
 
   let content_id = req.body.content_id;
 
-  let kb = await KB.findById(content_id).catch( async (err) => {
-    winston.error("(webhook) Error getting kb content: ", err);
-    return res.status(500).send({ success: false, error: "Error getting content with id " + content_id });
-  })
-
-  const namespace_id = kb.namespace;
-  let namespace;
+  let kb;
   try {
-    namespace = await aiManager.checkNamespace(kb.id_project, namespace_id);
+    kb = await KB.findById(content_id);
   } catch (err) {
-    let errorCode = err?.errorCode ?? 500;
-    return res.status(errorCode).send({ success: false, error: err.error });
+    winston.error("(webhook) Error getting kb content: ", err);
+    return res.status(500).send({ success: false, error: "Error getting content with id " + content_id });
   }
 
   if (!kb) {
@@ -99,8 +93,19 @@ router.post('/kb/reindex', async (req, res) => {
       winston.verbose("(webhook) delete response: ", deleteResponse);
       return;
     }, 10000);
-    
-  } else if (kb.type === 'sitemap') {
+    return;
+  }
+
+  const namespace_id = kb.namespace;
+  let namespace;
+  try {
+    namespace = await aiManager.checkNamespace(kb.id_project, namespace_id);
+  } catch (err) {
+    let errorCode = err?.errorCode ?? 500;
+    return res.status(errorCode).send({ success: false, error: err.error });
+  }
+
+  if (kb.type === 'sitemap') {
 
     const urls = await aiManager.fetchSitemap(kb.source).catch((err) => {
       winston.error("(webhook) Error fetching sitemap: ", err);