Skip to content

Commit 7edfb05

Browse files
committed
todo comment
1 parent 0a64556 commit 7edfb05

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/test/java/de/tilman_neumann/jml/factor/siqs/SIQSSmallTest.java

+5-3
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,12 @@ public static void setup() {
3838
}
3939

4040
@Test
41+
// TODO On github CI this test may need up to 13 seconds. Locally the test finishes in less than 100ms.
42+
// It is possible that the test numbers are not very appropriate for the algorithm, but why the difference between local and github tests?
4143
public void testSomeInputs() {
42-
assertFactorizationSuccess("15841065490425479923", "2604221509 * 6082841047");
43-
assertFactorizationSuccess("11111111111111111111111111", "11 * 53 * 79 * 859 * 265371653 * 1058313049");
44-
assertFactorizationSuccess("5679148659138759837165981543", "3^3 * 466932157 * 450469808245315337");
44+
assertFactorizationSuccess("15841065490425479923", "2604221509 * 6082841047"); // 64 bit
45+
assertFactorizationSuccess("11111111111111111111111111", "11 * 53 * 79 * 859 * 265371653 * 1058313049"); // 84 bit
46+
assertFactorizationSuccess("5679148659138759837165981543", "3^3 * 466932157 * 450469808245315337"); // 93 bit
4547

4648
// This number is already too big, it causes hanging github CI builds quite often
4749
//assertFactorizationSuccess("11111111111111111111111111155555555555111111111111111", "67 * 157 * 1056289676880987842105819104055096069503860738769");

0 commit comments

Comments
 (0)