Constructor support in source model

[frankfolsche]

I like the library but one thing is stopping me from using Facet. That is the fact that all my domain models don't have public properties.

It's good practice to setup domain models this way to prevent unwanted changes, as the readme specifically states domain models "Facet is a C# source generator that lets you define lightweight projections (DTOs, API models, etc.) directly from your domain models, without writing boilerplate." I found it strange it's not supported.

Is this by design or is this something that could be added in the future?

using Facet;

[Facet(typeof(Order))]
public partial class OrderDto;

[Facet(typeof(OrderLine))]
public partial class OrderLineDto;

public class Order
{
    public int Id { get; private set; }
    public List<OrderLine> Lines { get; private set; }
    public Order(List<OrderLine> lines)
    {
        Lines = lines;
    }

    public void AddLine(int quantity, string name)
    {
        Lines.Add(new OrderLine(quantity, name));
    }
}
public class OrderLine
{
    public int Quantity { get; private set; }
    public string Name { get; private set; }

    public OrderLine(int quantity, string name)
    {
        Quantity = quantity;
        Name = name;
    }
}

The property or indexer 'Order.Id' cannot be used in this context because the set accessor is inaccessible'

<PackageReference Include="Facet" Version="3.1.14" />
<PackageReference Include="Facet.Mapping" Version="3.1.14" />

[Tim-Maes]

Hey, a bit late to the party here, sorry. I believe this is currently no longer an issue? I tested it out locally, and could assert it in an unit test.

[frankfolsche]

Hi Tim,

I've double check my example and update it to version 3.1.14, Two mistakes in the post that made it a bit un clear what my actuall issue is.

I've updated the post. It's still the case that I can't build the abbove mentioned code, because my propties have a private set but the generated code does not use the constuctor but tries to set the private properties.