#1983 Editor fixes relating to version CRUD tasks.

GSE.ReplaceSequence stored the caller's own table into GSE.Library, so from
the first Save of a session the editor's working sequence and the Library
entry were the same object. Every per-version handler carries a "mirror into
the Library so the tree updates before Save" block, and post-Save that block
was writing into the same array a second time: Delete removed two versions,
New Version inserted two, drag reorder moved twice. The extra version also
left the tree pointing at an index the reloaded sequence did not have, which
is the nil-index error on the way back into the editor. The Library now holds
a clone, which is the invariant those mirror blocks were written against —
fixed at the source rather than by guarding each mirror site.

New Version left the Save button disabled. The macro-length gate is the only
thing that disables Save, and the newversion branch refreshed it BEFORE
inserting, so it measured the previously selected version; if that one was
over the limit, a brand-new copy of Default inherited a disabled Save and
nothing re-evaluated it until macro text happened to change.
GUIDrawMacroEditor does not refresh the gate itself, so the branch now does
it against the new index.

Version-delete metadata rules, which were wrong in both directions:
  - MetaData.Default was decremented on EVERY delete, so removing version 5
    while Default was 4 silently moved Default to 3 and the sequence ran a
    macro the author never chose. Only references AFTER the deleted version
    move now.
  - A context override pointing AT the deleted version was silently
    repointed at Default. It now blocks the delete and names the entries to
    change first, the same way Default already did.

The rule and the key list move to Storage.lua as GSE.VersionReferencesInUse
and GSE.ShiftVersionReferencesAfterDelete, with the keys derived from
contextVersionPriority instead of hand-listed. The editor had three separate
copies of that list; a context added to the runtime and missed in one of them
is a reference silently left pointing at the wrong version.

Drops the ten "X setting changed to Default." strings, dead now that the
silent repoint is gone. No other locale carried them.

spec/versionrefs_spec.lua covers the three delete cases, the ten keys, string
indexes, junk input, and that the Library no longer aliases the caller.
163 busted tests, luacheck clean.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wmCKbEwmEgWW8SpWnXJhC

Author: TimothyLuke

GSE/API/Storage.lua

@@ -514,21 +514,35 @@ function GSE.SnapshotDependentMacros(sequence)
 end
 
 --- Replace a current version of a Macro
+--- Store a sequence into the Library and the saved variables.
+--
+-- The Library entry is a CLONE, never the caller's own table. The editor keeps
+-- its working copy in editframe.Sequence and hands that same table here on
+-- Save; storing it directly made the two the same object, and from the first
+-- Save of a session onwards every per-version operation ran twice — once as
+-- the editor's own edit, then again through the "mirror into the Library so
+-- the tree updates before Save" block in each handler, which was by then
+-- writing into the same array. Delete removed two versions, New Version
+-- inserted two, drag reorder moved twice. The extra version also left the
+-- tree pointing at an index the reloaded sequence did not have, which is the
+-- nil-index error on the way back into the editor. Cloning restores the
+-- invariant those mirror blocks were written against: the Library holds a
+-- separate copy that only this function replaces.
 function GSE.ReplaceSequence(classid, sequenceName, sequence)
     if GSE.SanitizeSequenceEditorMarkup then
         GSE.SanitizeSequenceEditorMarkup(sequence)
     end
     GSE.ComputeSequenceDependencies(sequence)
     GSE.SnapshotDependentMacros(sequence)
     if GSE.UpdateDeltaFork and GSE.UpdateDeltaFork(sequence) then
-        GSE.Library[classid][sequenceName] = sequence
+        GSE.Library[classid][sequenceName] = GSE.CloneSequence(sequence)
         GSE:SendMessage(Statics.Messages.SEQUENCE_UPDATED, sequenceName)
         return
     end
     -- Checksum is stamped on export only, not on save, so the stored checksum
     -- always reflects the last-exported state rather than the current edit state.
     GSESequences[classid][sequenceName] = GSE.EncodeMessage({sequenceName, sequence})
-    GSE.Library[classid][sequenceName] = sequence
+    GSE.Library[classid][sequenceName] = GSE.CloneSequence(sequence)
     GSE:SendMessage(Statics.Messages.SEQUENCE_UPDATED, sequenceName)
 end
 
@@ -1038,6 +1052,70 @@ local contextVersionPriority = {
     { metaKey = "Party",       flag = "inParty",       valueKey = "Party"       },
 }
 
+--- Every MetaData key that holds a VERSION NUMBER, derived from
+-- contextVersionPriority above rather than repeated. PVP appears twice in
+-- that table (once routing to Arena), so dedupe on valueKey.
+local contextVersionKeys = {}
+do
+    local seen = {}
+    for _, entry in ipairs(contextVersionPriority) do
+        if entry.valueKey and not seen[entry.valueKey] then
+            seen[entry.valueKey] = true
+            contextVersionKeys[#contextVersionKeys + 1] = entry.valueKey
+        end
+    end
+end
+
+--- The context keys, in priority order. Callers must not mutate the result.
+function GSE.GetContextVersionKeys()
+    return contextVersionKeys
+end
+
+--- Which MetaData entries point AT `version`.
+-- Returns a list of key names, empty when nothing references it. Deleting a
+-- version that something points at is refused rather than silently repointed:
+-- an author who set Raid to version 4 chose that, and moving it to Default
+-- behind their back changes which macro fires in a raid.
+function GSE.VersionReferencesInUse(metadata, version)
+    local inUse = {}
+    if type(metadata) ~= "table" then return inUse end
+    version = tonumber(version)
+    if not version then return inUse end
+    if tonumber(metadata.Default) == version then inUse[#inUse + 1] = "Default" end
+    for _, key in ipairs(contextVersionKeys) do
+        if tonumber(metadata[key]) == version then inUse[#inUse + 1] = key end
+    end
+    return inUse
+end
+
+--- Move every version reference down one slot after `version` was deleted.
+--
+-- Only references AFTER the deleted version move — what they point at slid
+-- down by one. A reference BEFORE it cannot be affected: deleting a later
+-- version does not renumber earlier ones. A reference AT it never reaches
+-- here, because VersionReferencesInUse blocks the delete first.
+--
+-- Default used to be decremented unconditionally, so deleting version 5 while
+-- Default was 4 silently moved Default to 3 — the sequence then ran a macro
+-- the author never selected.
+function GSE.ShiftVersionReferencesAfterDelete(metadata, version)
+    if type(metadata) ~= "table" then return end
+    version = tonumber(version)
+    if not version then return end
+    local function shift(value)
+        local n = tonumber(value)
+        if n and n > version then return n - 1 end
+        return value
+    end
+    metadata.Default = shift(metadata.Default)
+    for _, key in ipairs(contextVersionKeys) do
+        if not GSE.isEmpty(metadata[key]) then
+            metadata[key] = shift(metadata[key])
+        end
+    end
+end
+
+
 local function isPVESoloContext()
     return not (
         GSE.inScenario or

GSE/Localization/ModL_enUS.lua

@@ -264,7 +264,6 @@ L[
     ] = true
 L["Macro Version %d deleted."] = true
 L["This change will not come into effect until you save this macro."] = true
-L["PVP setting changed to Default."] = true
 L["Delete"] = true
 L["Cancel"] = true
 L["Addin Version %s contained versions for the following sequences:"] = true
@@ -353,9 +352,6 @@ L["Gnome Sequencer: Compress a Sequence String."] = true
 L["Compress Sequence from Forums"] = true
 L["Sequence to Compress."] = true
 L["Compress"] = true
-L["Heroic setting changed to Default."] = true
-L["Dungeon setting changed to Default."] = true
-L["Party setting changed to Default."] = true
 L[
         "Macro found by the name %sPVP%s. Rename this macro to a different name to be able to use it.  WOW has a global object called PVP that is referenced instead of this macro."
     ] = true
@@ -365,7 +361,6 @@ L["Random - It will select .... a spell, any spell"] = true
 
 -- GSE 2.3.00
 L["The GUI has not been loaded.  Please activate this plugin amongst WoW's addons to use the GSE GUI."] = true
-L["Arena setting changed to Default."] = true
 L["Arena"] = true
 L["Local Macro"] = true
 L["Updated Macro"] = true
@@ -388,8 +383,6 @@ L[" was imported as a new macro."] = true
 L["New Sequence Name"] = true
 
 -- GSE 2.3.09
-L["Mythic+ setting changed to Default."] = true
-L["Timewalking setting changed to Default."] = true
 
 -- GSE 2.4.01
 L[
@@ -441,8 +434,6 @@ L["Hide Minimap Icon"] = true
 L["Hide Minimap Icon for LibDataBroker (LDB) data text."] = true
 
 -- GSE 2.4.15 - Missing translations
-L["Raid setting changed to Default."] = true
-L["Mythic setting changed to Default."] = true
 
 -- GSE 2.5.0
 L["The milliseconds being used in key click delay."] = true
@@ -457,7 +448,6 @@ L["Version"] = true
 
 -- 2.5.9
 L["The version of this macro to use in Delves and Scenarios."] = true
-L["Delves and Scenarios setting changed to Default."] = true
 
 -- 2.6.01
 L["Variables"] = true
@@ -951,3 +941,6 @@ L["The delay in seconds between Out of Combat Queue Polls.  The Out of Combat Qu
 L["The following people donate monthly via Patreon for the ongoing maintenance and development of GSE.  Their support is greatly appreciated."] = true
 L["These options combine to allow you to reset a sequence while it is running.  These options are Cumulative ie they add to each other.  Options Like LeftClick and RightClick won't work together very well."] = true
 L["This is a common WoW setting used by all addons; it controls when your action buttons respond.  On: they react when you press the key (key-down).  Off: they react when you release it (key-up).  GSE now works either way -- Actionbar Overrides and keybinds fire a single step in both states.  With this on, GSE keybinds also fire on key-down for a faster response.  Changes apply immediately out of combat (or on your next rebind if toggled mid-combat)."] = true
+L["Version %d is in use by: %s.  Point %s at another version on the Configuration tab before deleting this one."] = true
+L["it"] = true
+L["them"] = true

GSE_GUI/Editor.lua

@@ -5973,6 +5973,29 @@ function GSE.CreateEditor()
                     )
                     return
                 end
+
+                -- A context override pointing AT this version blocks the delete
+                -- the same way Default does. Silently repointing it at Default
+                -- (what this used to do) changes which macro fires in that
+                -- context without telling the author — they set Raid to version
+                -- 4 deliberately. Make them repoint it first. The key list and
+                -- the rule live in Storage.lua, derived from
+                -- contextVersionPriority, so the editor cannot drift from the
+                -- runtime's idea of which contexts exist.
+                local blocking = GSE.VersionReferencesInUse(sequence.MetaData, version)
+                if #blocking > 0 then
+                    GSE.Print(
+                        string.format(
+                            L["Version %d is in use by: %s.  Point %s at another version on the Configuration tab before deleting this one."],
+                            version,
+                            table.concat(blocking, ", "),
+                            #blocking == 1 and L["it"] or L["them"]
+                        ),
+                        Statics.DebugModules["Editor"]
+                    )
+                    return
+                end
+
                 GSE.UI.ShowConfirmDialog({
                     owner       = editframe,
                     title       = L["Delete Version"],
@@ -5987,113 +6010,11 @@ function GSE.CreateEditor()
                     cancelText  = L["Cancel"],
                     onConfirm   = function()
                     local printtext = L["Macro Version %d deleted."]
-                    if sequence.MetaData.PVP == version then
-                        sequence.MetaData.PVP = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["PVP setting changed to Default."]
-                    end
-                    if sequence.MetaData.Arena == version then
-                        sequence.MetaData.Arena = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Arena setting changed to Default."]
-                    end
-                    if sequence.MetaData.Raid == version then
-                        sequence.MetaData.Raid = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Raid setting changed to Default."]
-                    end
-                    if sequence.MetaData.Mythic == version then
-                        sequence.MetaData.Mythic = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Mythic setting changed to Default."]
-                    end
-                    if sequence.MetaData.Heroic == version then
-                        sequence.MetaData.Heroic = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Heroic setting changed to Default."]
-                    end
-                    if sequence.MetaData.Dungeon == version then
-                        sequence.MetaData.Dungeon = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Dungeon setting changed to Default."]
-                    end
-                    if sequence.MetaData.Party == version then
-                        sequence.MetaData.Party = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Party setting changed to Default."]
-                    end
-                    if sequence.MetaData.MythicPlus == version then
-                        sequence.MetaData.MythicPlus = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Mythic+ setting changed to Default."]
-                    end
-                    if sequence.MetaData.Timewalking == version then
-                        sequence.MetaData.Timewalking = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Timewalking setting changed to Default."]
-                    end
-                    if sequence.MetaData.Scenario == version then
-                        sequence.MetaData.Scenario = sequence.MetaData.Default
-                        printtext = printtext .. " " .. L["Delves and Scenarios setting changed to Default."]
-                    end
 
-                    if sequence.MetaData.Default > 1 then
-                        sequence.MetaData.Default = tonumber(sequence.MetaData.Default) - 1
-                    else
-                        sequence.MetaData.Default = 1
-                    end
+                    -- Only references after the deleted version move; see
+                    -- GSE.ShiftVersionReferencesAfterDelete for the three cases.
+                    GSE.ShiftVersionReferencesAfterDelete(sequence.MetaData, version)
 
-                    if
-                        not GSE.isEmpty(sequence.MetaData.PVP) and sequence.MetaData.PVP > 1 and
-                            sequence.MetaData.PVP >= version
-                     then
-                        sequence.MetaData.PVP = tonumber(sequence.MetaData.PVP) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.Arena) and sequence.MetaData.Arena > 1 and
-                            sequence.MetaData.Arena >= version
-                     then
-                        sequence.MetaData.Arena = tonumber(sequence.MetaData.Arena) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.Raid) and sequence.MetaData.Raid > 1 and
-                            sequence.MetaData.Raid >= version
-                     then
-                        sequence.MetaData.Raid = tonumber(sequence.MetaData.Raid) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.Mythic) and sequence.MetaData.Mythic > 1 and
-                            sequence.MetaData.Mythic >= version
-                     then
-                        sequence.MetaData.Mythic = tonumber(sequence.MetaData.Mythic) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.MythicPlus) and sequence.MetaData.MythicPlus > 1 and
-                            sequence.MetaData.MythicPlus >= version
-                     then
-                        sequence.MetaData.MythicPlus = tonumber(sequence.MetaData.MythicPlus) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.Timewalking) and sequence.MetaData.Timewalking > 1 and
-                            sequence.MetaData.Timewalking >= version
-                     then
-                        sequence.MetaData.Timewalking = tonumber(sequence.MetaData.Timewalking) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.Heroic) and sequence.MetaData.Heroic > 1 and
-                            sequence.MetaData.Heroic >= version
-                     then
-                        sequence.MetaData.Heroic = tonumber(sequence.MetaData.Heroic) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.Dungeon) and sequence.MetaData.Dungeon > 1 and
-                            sequence.MetaData.Dungeon >= version
-                     then
-                        sequence.MetaData.Dungeon = tonumber(sequence.MetaData.Dungeon) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.Party) and sequence.MetaData.Party > 1 and
-                            sequence.MetaData.Party >= version
-                     then
-                        sequence.MetaData.Party = tonumber(sequence.MetaData.Party) - 1
-                    end
-                    if
-                        not GSE.isEmpty(sequence.MetaData.Scenario) and sequence.MetaData.Scenario > 1 and
-                            sequence.MetaData.Scenario >= version
-                     then
-                        sequence.MetaData.Scenario = tonumber(sequence.MetaData.Scenario) - 1
-                    end
                     table.remove(sequence.Versions, version)
 
                     -- Mirror the deletion into the Library display cache so the
@@ -6110,11 +6031,7 @@ function GSE.CreateEditor()
                             table.remove(libSeq.Versions, version)
                             if libSeq.MetaData then
                                 libSeq.MetaData.Default = sequence.MetaData.Default
-                                local contextKeys = {
-                                    "Raid", "Arena", "Mythic", "MythicPlus", "PVP",
-                                    "Heroic", "Dungeon", "Timewalking", "Party", "Scenario",
-                                }
-                                for _, ck in ipairs(contextKeys) do
+                                for _, ck in ipairs(GSE.GetContextVersionKeys()) do
                                     libSeq.MetaData[ck] = sequence.MetaData[ck]
                                 end
                             end

GSE_GUI/Editor_Tree.lua

@@ -1292,6 +1292,17 @@ local function onClick_Sequences(editframe, container, group, unique, path, key,
         end
 
         editframe.GUIDrawMacroEditor(contentcontainer, newVersionIndex, table.concat(path, "\001"))
+
+        -- Recompute the Save gate for the version we just drew. The refresh
+        -- higher up in this branch ran BEFORE the insert, so it measured the
+        -- previously selected version: if that one was over the macro-length
+        -- limit, the brand-new version — a copy of Default, comfortably under
+        -- it — inherited a disabled Save button, and nothing re-evaluated it
+        -- until the author happened to edit macro text. GUIDrawMacroEditor
+        -- does not refresh this itself.
+        if editframe.RefreshMacroLimitSaveState then
+            editframe:RefreshMacroLimitSaveState(newVersionIndex)
+        end
         editframe:SetTitle(
             L["Sequence Editor"] .. ": " .. sequencename .. " (" .. L["New"] .. " " .. L["Version"] .. ")"
         )