Skip to content

Should retry set to true by default #221

Open
@georgi-mirchev

Description

What is this? This InnerWebSocketListener() is not injected but rather created in the OkHttpWebSocketChannel.open() function. This leads to the behavior where shouldRetry is always set to true but there are cases where this should be false. Like a 404 response for an example. Why do you need to retry when the URL cannot be found? This needs to be done in a configurable manner meaning InnerWebSocketListener() should be injected and not created inside the function.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions