Axes confusion

[mattvenn]

From Harald Pretl: I was super confused at first about the axes. They should have labels as to what the axis is. It took a while (and a look into the SPICE code) to realize this is based on a transient sim 🙂 The unit (s) should be shown at the x-axis. Likewise, the y-axis only shows volts, but not since volt and current is shown, a second axis would be good. Not sure how well this could be implemented, though.

[urish]

Done, went with "seconds" and "volts', but feel free to change in

siliwiz/src/components/Graph.tsx

Line 22 in ca5da1f

text: 'seconds',

as needed

[mattvenn]

this doesn't help with the issue that current is shown

[urish]

Current is only shown in specific simulations, right?

You get a hint about that from the legend:

As a quick-win, we can probably add a heuristic that if any of the signal labels start with "i(", we change the axis to say "Volts or Amps". WDYT?

[mattvenn]

well the blue is volts and the orange is amps. so maybe it's best to have a legend instead of labelling the axis?

[urish]

So remove the y-axis label and keep the legend as is?

We can also change the default labels to be v(in) and v(out) to make it more obvious that we're talking voltages

[urish]

Something along these lines:

[mattvenn]

yes, or how about coloring the 'plot signals' at the bottom. so v(in) has a blue border and v(out) has a orange border).
still doesn't help with units on the axes though

[urish]

coloring the 'plot signals' would be more complex, but I can look into that.

So should I go for the v(in) and v(out) change?