Skip to content

Commit 2e0f6f1

Browse files
authored
Fix: Prevent formatting=false throwing an error (#4819)
1 parent 2663dc9 commit 2e0f6f1

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

sqlmesh/core/model/definition.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2886,6 +2886,7 @@ def render_expression(
28862886
for name, args in values
28872887
)
28882888
),
2889+
"formatting": str,
28892890
}
28902891

28912892

tests/core/test_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9973,9 +9973,9 @@ def test_formatting_flag_serde():
99739973
)
99749974

99759975
model = load_sql_based_model(expressions)
9976+
assert model.render_definition()[0].sql() == "MODEL (\nname test_model,\nformatting False\n)"
99769977

99779978
model_json = model.json()
9978-
99799979
assert "formatting" not in json.loads(model_json)
99809980

99819981
deserialized_model = SqlModel.parse_raw(model_json)

0 commit comments

Comments
 (0)