PR Feedback 2

Author: VaggelisD

sqlmesh/core/context.py

@@ -451,7 +451,7 @@ def snapshot_evaluator(self, job_id: t.Optional[CorrelationId] = None) -> Snapsh
         if job_id not in self._snapshot_evaluators:
             self._snapshot_evaluators[job_id] = SnapshotEvaluator(
                 {
-                    gateway: adapter.with_settings(level=logging.INFO, job_id=job_id)
+                    gateway: adapter.with_settings(log_level=logging.INFO, job_id=job_id)
                     for gateway, adapter in self.engine_adapters.items()
                 },
                 ddl_concurrent_tasks=self.concurrent_tasks,

sqlmesh/core/engine_adapter/base.py

@@ -147,13 +147,13 @@ def __init__(
         self._multithreaded = multithreaded
         self._job_id = job_id
 
-    def with_settings(self, level: int, **kwargs: t.Any) -> EngineAdapter:
+    def with_settings(self, log_level: int, **kwargs: t.Any) -> EngineAdapter:
         adapter = self.__class__(
             self._connection_pool,
             dialect=self.dialect,
             sql_gen_kwargs=self._sql_gen_kwargs,
             default_catalog=self._default_catalog,
-            execute_log_level=level,
+            execute_log_level=log_level,
             register_comments=self._register_comments,
             null_connection=True,
             multithreaded=self._multithreaded,

sqlmesh/utils/__init__.py

@@ -389,8 +389,10 @@ def to_snake_case(name: str) -> str:
 
 
 class JobType(Enum):
-    PLAN = "PLAN"
-    RUN = "RUN"
+    PLAN = "SQLMESH_PLAN"
+
+
+RUN = "SQLMESH_RUN"
 
 
 @dataclass(frozen=True)

tests/core/test_integration.py

@@ -6485,7 +6485,7 @@ def _correlation_id_in_sqls(correlation_id: CorrelationId, mock_logger):
         plan = ctx.plan(auto_apply=True, no_prompts=True)
 
     correlation_id = CorrelationId.from_plan(plan)
-    assert str(correlation_id) == f"PLAN: {plan.plan_id}"
+    assert str(correlation_id) == f"SQLMESH_PLAN: {plan.plan_id}"
 
     assert _correlation_id_in_sqls(correlation_id, mock_logger)