Rename to always_recreate_environment, PR feedback 3

Author: VaggelisD

docs/guides/configuration.md

@@ -386,15 +386,15 @@ Example showing default values:
 
 By default, SQLMesh compares the current state of project files to the target `<env>` environment when `sqlmesh plan <env>` is run. However, a common expectation is that local changes should always be compared to the production environment.
 
-The `always_init_from_prod` boolean plan option can alter this behavior. When enabled, SQLMesh will always attempt to compare against the production environment; If that does not exist, SQLMesh will fall back to comparing against the target environment.
+The `always_recreate_environment` boolean plan option can alter this behavior. When enabled, SQLMesh will always attempt to compare against the production environment by recreating the target environment; If `prod` does not exist, SQLMesh will fall back to comparing against the target environment.
 
 **NOTE:**: Upon succesfull plan application, changes are still promoted to the target `<env>` environment.
 
 === "YAML"
 
     ```yaml linenums="1"
     plan:
-        always_init_from_prod: True
+        always_recreate_environment: True
     ```
 
 === "Python"
@@ -416,7 +416,7 @@ The `always_init_from_prod` boolean plan option can alter this behavior. When en
 
 #### Change Categorization Example
 
-Consider this scenario with `always_init_from_prod` enabled:
+Consider this scenario with `always_recreate_environment` enabled:
 
 1. Initial state in `prod`:
 ```sql

docs/reference/configuration.md

@@ -80,7 +80,7 @@ Configuration for the `sqlmesh plan` command.
 | `enable_preview`          | Indicates whether to enable [data preview](../concepts/plans.md#data-preview) for forward-only models when targeting a development environment (Default: True, except for dbt projects where the target engine does not support cloning)                | Boolean              | N        |
 | `no_diff`                 | Don't show diffs for changed models (Default: False)                                                                                                                                                                                                    | boolean              | N        |
 | `no_prompts`              | Disables interactive prompts in CLI (Default: True)                                                                                                                                                                                                     | boolean              | N        |
-| `always_init_from_prod`              | Always recreates the target environment from the environment specified in `create_from` (by default `prod`) (Default: False)                                                                                                                                                                                                     | boolean              | N        |
+| `always_recreate_environment`              | Always recreates the target environment from the environment specified in `create_from` (by default `prod`) (Default: False)                                                                                                                                                                                                     | boolean              | N        |
 ## Run
 
 Configuration for the `sqlmesh run` command. Please note that this is only applicable when configured with the [builtin](#builtin) scheduler.

sqlmesh/core/config/plan.py

@@ -20,7 +20,7 @@ class PlanConfig(BaseConfig):
         auto_apply: Whether to automatically apply the new plan after creation.
         use_finalized_state: Whether to compare against the latest finalized environment state, or to use
             whatever state the target environment is currently in.
-        always_init_from_prod: Whether to always recreate the target environment from the prod environment.
+        always_recreate_environment: Whether to always recreate the target environment from the prod environment.
     """
 
     forward_only: bool = False
@@ -31,4 +31,4 @@ class PlanConfig(BaseConfig):
     no_prompts: bool = True
     auto_apply: bool = False
     use_finalized_state: bool = False
-    always_init_from_prod: bool = False
+    always_recreate_environment: bool = False

sqlmesh/core/console.py

@@ -1532,7 +1532,6 @@ def show_environment_difference_summary(
         Args:
             context_diff: The context diff to use to print the summary
             no_diff: Hide the actual environment statement differences.
-            environment: The initial target environment
         """
         if context_diff.is_new_environment:
             msg = (
@@ -2905,7 +2904,6 @@ def show_environment_difference_summary(
         Args:
             context_diff: The context diff to use to print the summary.
             no_diff: Hide the actual environment statements differences.
-            environment: The initial target environment
         """
         if context_diff.is_new_environment:
             msg = (

sqlmesh/core/context.py

@@ -1484,7 +1484,7 @@ def plan_builder(
             or (backfill_models is not None and not backfill_models),
             ensure_finalized_snapshots=self.config.plan.use_finalized_state,
             diff_rendered=diff_rendered,
-            always_init_from_prod=self.config.plan.always_init_from_prod,
+            always_recreate_environment=self.config.plan.always_recreate_environment,
         )
         modified_model_names = {
             *context_diff.modified_snapshots,
@@ -2609,7 +2609,7 @@ def _context_diff(
         force_no_diff: bool = False,
         ensure_finalized_snapshots: bool = False,
         diff_rendered: bool = False,
-        always_init_from_prod: bool = False,
+        always_recreate_environment: bool = False,
     ) -> ContextDiff:
         environment = Environment.sanitize_name(environment)
         if force_no_diff:
@@ -2627,7 +2627,7 @@ def _context_diff(
             environment_statements=self._environment_statements,
             gateway_managed_virtual_layer=self.config.gateway_managed_virtual_layer,
             infer_python_dependencies=self.config.infer_python_dependencies,
-            always_init_from_prod=always_init_from_prod,
+            always_recreate_environment=always_recreate_environment,
         )
 
     def _destroy(self) -> None:

sqlmesh/core/context_diff.py

@@ -104,7 +104,7 @@ def create(
         environment_statements: t.Optional[t.List[EnvironmentStatements]] = [],
         gateway_managed_virtual_layer: bool = False,
         infer_python_dependencies: bool = True,
-        always_init_from_prod: bool = False,
+        always_recreate_environment: bool = False,
     ) -> ContextDiff:
         """Create a ContextDiff object.
 
@@ -133,7 +133,7 @@ def create(
         existing_env = state_reader.get_environment(environment)
         create_from_env_exists = False
 
-        if existing_env is None or existing_env.expired or always_init_from_prod:
+        if existing_env is None or existing_env.expired or always_recreate_environment:
             env = state_reader.get_environment(create_from.lower())
 
             if not env and create_from != c.PROD:
@@ -223,7 +223,7 @@ def create(
 
         previous_environment_statements = state_reader.get_environment_statements(environment)
 
-        if existing_env and always_init_from_prod:
+        if existing_env and always_recreate_environment:
             previous_plan_id: t.Optional[str] = existing_env.plan_id
         else:
             previous_plan_id = env.plan_id if env and not is_new_environment else None

sqlmesh/core/plan/builder.py

@@ -157,7 +157,7 @@ def __init__(
         self.override_end = end is not None
         self.environment_naming_info = EnvironmentNamingInfo.from_environment_catalog_mapping(
             environment_catalog_mapping or {},
-            name=environment,
+            name=self._context_diff.environment,
             suffix_target=environment_suffix_target,
             normalize_name=self._context_diff.normalize_environment_name,
             gateway_managed=self._context_diff.gateway_managed_virtual_layer,

tests/core/test_integration.py

@@ -6212,7 +6212,7 @@ def test_render_path_instead_of_model(tmp_path: Path):
 
 
 @use_terminal_console
-def test_plan_always_init_from_prod(tmp_path: Path):
+def test_plan_always_recreate_environment(tmp_path: Path):
     def plan_with_output(ctx: Context, environment: str):
         with patch.object(logger, "info") as mock_logger:
             with capture_output() as output:
@@ -6232,7 +6232,7 @@ def plan_with_output(ctx: Context, environment: str):
         tmp_path, models_dir / "a.sql", "MODEL (name test.a, kind FULL); SELECT 1 AS col"
     )
 
-    config = Config(plan=PlanConfig(always_init_from_prod=True))
+    config = Config(plan=PlanConfig(always_recreate_environment=True))
     ctx = Context(paths=[tmp_path], config=config)
 
     # Case 1: Neither prod nor dev exists, so dev is initialized