Ensure plan option does not work if target env == create_from

Author: VaggelisD

sqlmesh/core/context_diff.py

@@ -132,7 +132,9 @@ def create(
         existing_env = state_reader.get_environment(environment)
         create_from_env_exists = False
 
-        if existing_env is None or existing_env.expired or always_recreate_environment:
+        recreate_environment = always_recreate_environment and not environment == create_from
+
+        if existing_env is None or existing_env.expired or recreate_environment:
             env = state_reader.get_environment(create_from.lower())
 
             if not env and create_from != c.PROD:

tests/core/test_integration.py

@@ -6345,7 +6345,11 @@ def plan_with_output(ctx: Context, environment: str):
         in output.stdout
     )
 
-    # Case 6: Check that we can still run Context::diff() against any environment
+    # Case 6: Ensure that target environment and create_from environment are not the same
+    output = plan_with_output(ctx, "prod")
+    assert not "New environment `prod` will be created from `prod`" in output.stdout
+
+    # Case 7: Check that we can still run Context::diff() against any environment
     for environment in ["dev", "prod"]:
         context_diff = ctx._context_diff(environment)
         assert context_diff.environment == environment