PR feedback

Author: erindru

sqlmesh/core/engine_adapter/snowflake.py

@@ -300,7 +300,7 @@ def query_factory() -> Query:
                 temp_table.set("catalog", database)
                 df_renamed = df.rename(
                     {
-                        col: exp.to_identifier(col, quoted=True).sql(dialect=self.dialect)
+                        col: exp.to_identifier(col).sql(dialect=self.dialect, identify=True)
                         for col in columns_to_types
                     }
                 )  # type: ignore

sqlmesh/core/engine_adapter/spark.py

@@ -281,7 +281,7 @@ def _ensure_pyspark_df(
         if pyspark_df:
             if columns_to_types:
                 # ensure Spark dataframe column order matches columns_to_types
-                pyspark_df = pyspark_df.select(*list(columns_to_types))
+                pyspark_df = pyspark_df.select(*columns_to_types)
             return pyspark_df
         df = self.try_get_pandas_df(generic_df)
         if df is None:

tests/core/engine_adapter/integration/test_integration.py

@@ -2736,14 +2736,13 @@ def _use_warehouse_as_state_connection(gateway_name: str, config: Config):
     sqlmesh_context.migrate()
 
 
-def test_python_model_column_order(ctx: TestContext, tmp_path_factory: pytest.TempPathFactory):
+def test_python_model_column_order(ctx: TestContext, tmp_path: pathlib.Path):
     if ctx.test_type == "pyspark" and ctx.dialect in ("spark", "databricks"):
         # dont skip
         pass
     elif ctx.test_type != "df":
         pytest.skip("python model column order test only needs to be run once per db")
 
-    tmp_path = tmp_path_factory.mktemp(f"column_order_{ctx.test_id}")
     schema = ctx.add_test_suffix(TEST_SCHEMA)
 
     (tmp_path / "models").mkdir()