Skip to content

Commit 2cc8daf

Browse files
committed
cleanup: Remove redundant Messenger and DHT tests.
These don't test anything that isn't covered by higher level tox tests. These are also not unit tests and have never found any bug that wasn't also caught by other tests. This makes them a pure maintenance burden.
1 parent ad2ed9e commit 2cc8daf

File tree

9 files changed

+2
-1104
lines changed

9 files changed

+2
-1104
lines changed

.cirrus.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ bazel-tsan_task:
8686
//c-toxcore/...
8787
-//c-toxcore/auto_tests:conference_av_test
8888
-//c-toxcore/auto_tests:conference_test
89-
-//c-toxcore/auto_tests:dht_test
9089
-//c-toxcore/auto_tests:file_transfer_test
9190
-//c-toxcore/auto_tests:onion_test
9291
-//c-toxcore/auto_tests:tcp_relay_test
@@ -111,7 +110,6 @@ bazel-valgrind_task:
111110
//c-toxcore/...
112111
-//c-toxcore/auto_tests:conference_av_test
113112
-//c-toxcore/auto_tests:conference_test
114-
-//c-toxcore/auto_tests:dht_test
115113
-//c-toxcore/auto_tests:encryptsave_test
116114
-//c-toxcore/auto_tests:file_transfer_test
117115
-//c-toxcore/auto_tests:onion_test

CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,6 @@ auto_test(conference_peer_nick)
454454
auto_test(conference_simple)
455455
auto_test(conference_two)
456456
auto_test(crypto)
457-
#auto_test(dht) # Doesn't work with UNITY_BUILD.
458457
auto_test(dht_getnodes_api)
459458
auto_test(encryptsave)
460459
auto_test(file_transfer)
@@ -467,7 +466,6 @@ auto_test(invalid_udp_proxy)
467466
auto_test(lan_discovery)
468467
auto_test(lossless_packet)
469468
auto_test(lossy_packet)
470-
auto_test(messenger)
471469
auto_test(network)
472470
auto_test(onion)
473471
auto_test(overflow_recvq)

auto_tests/BUILD.bazel

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ flaky_tests = {
4444
":check_compat",
4545
"//c-toxcore/testing:misc_tools",
4646
"//c-toxcore/toxav",
47-
"//c-toxcore/toxcore:DHT_srcs",
48-
"//c-toxcore/toxcore:Messenger",
4947
"//c-toxcore/toxcore:TCP_client",
5048
"//c-toxcore/toxcore:TCP_common",
5149
"//c-toxcore/toxcore:TCP_connection",

auto_tests/Makefile.inc

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ TESTS = \
1212
conference_test \
1313
conference_two_test \
1414
crypto_test \
15-
dht_test \
1615
file_transfer_test \
1716
friend_connection_test \
1817
friend_request_test \
@@ -21,7 +20,6 @@ TESTS = \
2120
lan_discovery_test \
2221
lossless_packet_test \
2322
lossy_packet_test \
24-
messenger_test \
2523
network_test \
2624
onion_test \
2725
overflow_recvq_test \
@@ -99,10 +97,6 @@ crypto_test_SOURCES = ../auto_tests/crypto_test.c
9997
crypto_test_CFLAGS = $(AUTOTEST_CFLAGS)
10098
crypto_test_LDADD = $(AUTOTEST_LDADD)
10199

102-
dht_test_SOURCES = ../auto_tests/dht_test.c
103-
dht_test_CFLAGS = $(AUTOTEST_CFLAGS)
104-
dht_test_LDADD = $(AUTOTEST_LDADD)
105-
106100
encryptsave_test_SOURCES = ../auto_tests/encryptsave_test.c
107101
encryptsave_test_CFLAGS = $(AUTOTEST_CFLAGS)
108102
encryptsave_test_LDADD = $(AUTOTEST_LDADD)
@@ -143,10 +137,6 @@ lossy_packet_test_SOURCES = ../auto_tests/lossy_packet_test.c
143137
lossy_packet_test_CFLAGS = $(AUTOTEST_CFLAGS)
144138
lossy_packet_test_LDADD = $(AUTOTEST_LDADD)
145139

146-
messenger_test_SOURCES = ../auto_tests/messenger_test.c
147-
messenger_test_CFLAGS = $(AUTOTEST_CFLAGS)
148-
messenger_test_LDADD = $(AUTOTEST_LDADD)
149-
150140
network_test_SOURCES = ../auto_tests/network_test.c
151141
network_test_CFLAGS = $(AUTOTEST_CFLAGS)
152142
network_test_LDADD = $(AUTOTEST_LDADD)

0 commit comments

Comments
 (0)