Merge pull request #157 from LucasB25/main

fix

Author: Tomato6966

package.json

@@ -55,12 +55,12 @@
   },
   "homepage": "https://tomato6966.github.io/lavalink-client/",
   "devDependencies": {
-    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/eslintrc": "^3.3.3",
     "@eslint/js": "^9.39.1",
     "@types/node": "^24.10.1",
     "@types/ws": "^8.18.1",
-    "@typescript-eslint/eslint-plugin": "^8.46.4",
-    "@typescript-eslint/parser": "^8.46.4",
+    "@typescript-eslint/eslint-plugin": "^8.48.0",
+    "@typescript-eslint/parser": "^8.48.0",
     "eslint": "^9.39.1",
     "tsup": "^8.5.1",
     "typescript": "^5.9.3"

src/structures/CustomSearches/BandCampSearch.ts

@@ -18,7 +18,14 @@ export const bandCampSearch = async (player: Player, query: string, requestUser:
             }
         });
 
-        const json = await data.json() as { results: { [key: string]: string }[] };
+        if (!data.ok) throw new Error(`Bandcamp Error: ${data.statusText}`);
+
+        let json;
+        try {
+            json = await data.json();
+        } catch {
+            throw new Error("Invalid JSON response from Bandcamp");
+        }
 
         tracks = json?.results?.filter(x => !!x && typeof x === "object" && "type" in x && x.type === "t").map?.(item => player.LavalinkManager.utils.buildUnresolvedTrack({
             uri: item.url || item.uri,
@@ -37,4 +44,4 @@ export const bandCampSearch = async (player: Player, query: string, requestUser:
         playlist: null,
         tracks: tracks
     } as UnresolvedSearchResult;
-}
+}

src/structures/Filters.ts

@@ -200,6 +200,8 @@ export class FilterManager {
     checkFiltersState(oldFilterTimescale?: Partial<TimescaleFilter>): boolean {
         this.data = this.data ?? {};
 
+        this.filters.audioOutput = (this.data.channelMix && this.filters.audioOutput !== "stereo") ? this.filters.audioOutput : "stereo";
+
         this.filters.rotation = this.privateNot0(this.data.rotation?.rotationHz);
         this.filters.vibrato = this.privateNot0(this.data.vibrato?.frequency) || this.privateNot0(this.data.vibrato?.depth);
         this.filters.tremolo = this.privateNot0(this.data.tremolo?.frequency) || this.privateNot0(this.data.tremolo?.depth);
@@ -814,7 +816,7 @@ export class FilterManager {
      * await player.filterManager.setEQPreset('BassboostMedium');
      * ```
      */
-    public async setEQPreset(preset : keyof typeof EQList): Promise<this> {
+    public async setEQPreset(preset: keyof typeof EQList): Promise<this> {
         const bands = EQList[preset];
         return this.setEQ(bands);
     }

src/structures/Node.ts

@@ -1057,7 +1057,6 @@ export class LavalinkNode {
     private async open(): Promise<void> {
         this.isAlive = true;
 
-        this.reconnectAttempts = 1;
         if (this.reconnectTimeout) clearTimeout(this.reconnectTimeout);
 
         // trigger heartbeat-ping timeout - this is to check wether the client lost connection without knowing it
@@ -1213,6 +1212,9 @@ export class LavalinkNode {
                 this.handleEvent(payload);
                 break;
             case "ready":  // payload: { resumed: false, sessionId: 'ytva350aevn6n9n8', op: 'ready' }
+                this.reconnectAttempts = 1;
+                clearTimeout(this.reconnectTimeout);
+
                 this.sessionId = payload.sessionId;
                 this.resuming.enabled = payload.resumed;
                 if (payload.resumed === true) {

src/structures/Queue.ts

@@ -280,9 +280,15 @@ export class Queue {
         // Log if available
         if ((TrackOrTracks) && typeof this.queueChanges?.tracksAdd === "function") try { this.queueChanges.tracksAdd(this.guildId, (Array.isArray(TrackOrTracks) ? TrackOrTracks : [TrackOrTracks]).flat(2).filter(v => this.managerUtils.isTrack(v) || this.managerUtils.isUnresolvedTrack(v)), index, oldStored, this.utils.toJSON()); } catch { /*  */ }
         // remove the tracks (and add the new ones)
-        let spliced = TrackOrTracks ? this.tracks.splice(index, amount, ...(Array.isArray(TrackOrTracks) ? TrackOrTracks : [TrackOrTracks]).flat(2).filter(v => this.managerUtils.isTrack(v) || this.managerUtils.isUnresolvedTrack(v))) : this.tracks.splice(index, amount);
-        // get the spliced array
-        spliced = (Array.isArray(spliced) ? spliced : [spliced]);
+        const spliced = TrackOrTracks
+            ? this.tracks.splice(
+                index,
+                amount,
+                ...(Array.isArray(TrackOrTracks) ? TrackOrTracks : [TrackOrTracks])
+                    .flat(2)
+                    .filter(v => this.managerUtils.isTrack(v) || this.managerUtils.isUnresolvedTrack(v))
+            )
+            : this.tracks.splice(index, amount);
         // Log if available
         if (typeof this.queueChanges?.tracksRemoved === "function") try { this.queueChanges.tracksRemoved(this.guildId, spliced, index, oldStored, this.utils.toJSON()) } catch { /* */ }
         // save the queue