Skip to content

Latest commit

 

History

History
53 lines (39 loc) · 1.98 KB

File metadata and controls

53 lines (39 loc) · 1.98 KB
name thermo-nuclear-code-quality-review
description 极严格的可维护性审查。用户要求 thermo-nuclear review、严厉代码质量审查、深度 maintainability audit、检查抽象/大文件/复杂度/意大利面式条件分支时使用。

Thermo-Nuclear Code Quality Review

Use this skill for a strict maintainability review of a diff or branch. Findings come first.

Review Standard

Be ambitious about simplification. Do not accept "it works" if the change makes the system harder to reason about.

Check for:

  • A simpler structure that removes whole branches, helpers, flags, or modes.
  • Files pushed toward or past 1,000 lines without a strong reason.
  • New one-off conditionals inserted into unrelated flows.
  • Business logic leaking into UI, hooks, or shared plumbing.
  • Service-layer code depending on React lifecycle or hooks.
  • Hook code containing business logic instead of event-to-state mapping.
  • Components importing service instances directly instead of consuming hooks.
  • any, unknown, broad casts, or optionality that hide unclear boundaries.
  • Sequential orchestration where independent work should be parallel or atomic.
  • Thin abstractions that add indirection without reducing complexity.

Workflow

  1. Collect git status --short, git diff --stat, and the relevant diff.
  2. Read changed files enough to understand boundaries and local style.
  3. Review by severity, not by file order.
  4. Report only actionable issues grounded in file/line references.
  5. If there are no issues, say so and name remaining test gaps.

Guardrails

  • Do not nitpick formatting while structural issues exist.
  • Do not request broad refactors unless the diff introduced or exposed the complexity.
  • Do not propose new dependencies.
  • Do not rewrite code during review unless the user asks for fixes.

Output

Findings
- [P0/P1/P2/P3] file:line - issue, impact, recommended fix

Open questions
- <only if blocking>

Test gaps / residual risk
- <only if relevant>