Enricher output mocking in tests - wip

Author: raphaelsolarski

defaultModel/src/main/scala/pl/touk/nussknacker/defaultmodel/migrations/DecisionTableParameterNamesMigration.scala

@@ -13,7 +13,7 @@ object DecisionTableParameterNamesMigration extends NodeMigration {
   override val description: String = "Change Decision Table component parameter names"
 
   override def migrateNode(metaData: MetaData): PartialFunction[node.NodeData, node.NodeData] = {
-    case enricher @ Enricher(_, service @ ServiceRef(_, params), _, _) =>
+    case enricher @ Enricher(_, service @ ServiceRef(_, params), _, _, _) =>
       enricher.copy(service = service.copy(parameters = renameParams(params)))
   }
 

designer/server/src/main/scala/pl/touk/nussknacker/ui/util/PdfExporter.scala

@@ -208,7 +208,7 @@ object PdfExporter extends LazyLogging {
       case Source(_, SourceRef(typ, params), _) =>
         ("Type", typ) :: params.map(p => (p.name.value, p.expression.expression))
       case Filter(_, expression, _, _) => List(("Expression", expression.expression))
-      case Enricher(_, ServiceRef(typ, params), output, _) =>
+      case Enricher(_, ServiceRef(typ, params), output, _, _) =>
         ("Type", typ) :: ("Output", output) :: params.map(p => (p.name.value, p.expression.expression))
       // TODO: what about Swtich??
       case Switch(_, expression, exprVal, _) => expression.map(e => ("Expression", e.expression)).toList

engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/SampleAdditionalInfoProvider.scala

@@ -14,7 +14,7 @@ class SampleAdditionalInfoProvider extends AdditionalInfoProvider {
 
   override def nodeAdditionalInfo(config: Config)(nodeData: node.NodeData): Future[Option[AdditionalInfo]] = {
     nodeData match {
-      case Enricher(_, ServiceRef("paramService", idParam :: Nil), _, _) =>
+      case Enricher(_, ServiceRef("paramService", idParam :: Nil), _, _, _) =>
         Future.successful(Some {
           val id = idParam.expression.expression.replace("'", "")
           MarkdownAdditionalInfo(s"""

scenario-api/src/main/scala/pl/touk/nussknacker/engine/graph/node.scala

@@ -195,7 +195,8 @@ object node {
       id: String,
       service: ServiceRef,
       output: String,
-      additionalFields: Option[UserDefinedAdditionalNodeFields] = None
+      additionalFields: Option[UserDefinedAdditionalNodeFields] = None,
+      mockExpression: Option[Expression] = None
   ) extends OneOutputSubsequentNodeData
       with WithComponent
       with WithParameters {

scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/Interpreter.scala

@@ -5,6 +5,7 @@ import cats.effect.IO
 import cats.syntax.all._
 import com.github.ghik.silencer.silent
 import pl.touk.nussknacker.engine.Interpreter._
+import pl.touk.nussknacker.engine.RuntimeMode.Test
 import pl.touk.nussknacker.engine.api._
 import pl.touk.nussknacker.engine.api.component.NodesDeploymentData
 import pl.touk.nussknacker.engine.api.exception.NuExceptionInfo
@@ -143,7 +144,12 @@ private class InterpreterInternal[F[_]: Monad](
               interpretationResult(node, FragmentEndReference(id, fields), newCtx)
             }
           )
-      case Enricher(_, ref, outName, next) =>
+      case Enricher(_, ref, outName, next, mockedOutput) =>
+        if (runtimeMode == Test && mockedOutput.isDefined) {
+          //todo: refactor
+          val valueWithModifiedContext = expressionEvaluator.evaluate[Any](mockedOutput.get, outName, node.id, ctx)
+          interpretNext(next, ctx.withVariable(outName, valueWithModifiedContext.value))
+        }
         invokeWrappedInInterpreterShape(ref, ctx).flatMap {
           case Left(ValueWithContext(out, newCtx)) => interpretNext(node, next, newCtx.withVariable(outName, out))
           case Right(exInfo)                       => Monad[F].pure(List(Right(exInfo)))

scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/PartSubGraphCompiler.scala

@@ -210,15 +210,19 @@ class PartSubGraphCompiler(nodeCompiler: NodeCompiler) {
           (ref, next) => compiledgraph.node.Processor(id, ref, next, isDisabled.contains(true))
         )
 
-      case enricher @ Enricher(id, _, output, _) =>
+      case enricher @ Enricher(id, _, output, _, mockExpression) =>
         val NodeCompilationResult(typingInfo, parameters, newCtx, validatedServiceRef, _) =
           nodeCompiler.compileEnricher(enricher, ctx, outputVar = OutputVar.enricher(output))
+        //tddo: compile expression
 
-        CompilationResult.map3(
+        //todo: type expression here and check if it match output variable type
+
+        CompilationResult.map4(
           toCompilationResult(validatedServiceRef, typingInfo, parameters),
           CompilationResult(newCtx),
-          compile(next, newCtx.getOrElse(ctx))
-        )((ref, _, next) => compiledgraph.node.Enricher(id, ref, output, next))
+          compile(next, newCtx.getOrElse(ctx)),
+
+        )((ref, _, next) => compiledgraph.node.Enricher(id, ref, output, next, ))
 
       // here we don't do anything, in subgraphcompiler it's just pass through, we can't add input context here because it contains output variable context (not input)
       case CustomNode(id, _, nodeType, _, _) =>

scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compiledgraph/node.scala

@@ -26,7 +26,7 @@ object node {
 
   case class EndingProcessor(id: String, service: ServiceRef, isDisabled: Boolean) extends Node
 
-  case class Enricher(id: String, service: ServiceRef, output: String, next: Next) extends Node
+  case class Enricher(id: String, service: ServiceRef, output: String, next: Next, mockedOutput: Option[CompiledExpression]) extends Node
 
   case class Filter(
       id: String,