NodeValidator: removed MissingParameters handling

Author: arkadius

designer/server/src/main/scala/pl/touk/nussknacker/ui/validation/NodeValidator.scala

@@ -4,8 +4,7 @@ import cats.effect.SyncIO
 import cats.effect.kernel.Resource
 import pl.touk.nussknacker.engine.{ModelData, ScenarioCompilationDependencies}
 import pl.touk.nussknacker.engine.api.{JobData, ProcessVersion}
-import pl.touk.nussknacker.engine.api.context.{ProcessCompilationError, ValidationContext}
-import pl.touk.nussknacker.engine.api.context.ProcessCompilationError.MissingParameters
+import pl.touk.nussknacker.engine.api.context.ValidationContext
 import pl.touk.nussknacker.engine.api.definition.EngineScenarioCompilationDependencies
 import pl.touk.nussknacker.engine.api.typed.typing.TypingResult
 import pl.touk.nussknacker.engine.compile.FragmentResolver
@@ -67,16 +66,7 @@ class NodeValidator(
               )
             case ValidationPerformed(errors, parameters, expressionType) =>
               val uiParams = parameters.map(_.map(DefinitionsService.createUIParameter))
-
-              // We don't return MissingParameter error when we are returning those missing parameters to be added - since
-              // it's not really exception ATM
-              def shouldIgnoreError(pce: ProcessCompilationError): Boolean = pce match {
-                case MissingParameters(params, _) =>
-                  params.forall(missing => uiParams.exists(_.exists(_.name == missing.value)))
-                case _ => false
-              }
-
-              val uiErrors = errors.filterNot(shouldIgnoreError).map(PrettyValidationErrors.formatErrorMessage)
+              val uiErrors = errors.map(PrettyValidationErrors.formatErrorMessage)
               NodeValidationResult(
                 parameters = uiParams,
                 expressionType = expressionType,

scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/NodeParametersAdjuster.scala

@@ -1,13 +1,10 @@
 package pl.touk.nussknacker.engine.compile
 
 import cats.Id
-import cats.data.{NonEmptySet, WriterT}
-import cats.data.Validated.valid
+import cats.data.WriterT
 import cats.implicits.toTraverseOps
-import cats.instances.set
 import com.typesafe.scalalogging.LazyLogging
 import pl.touk.nussknacker.engine.api.{JobData, NodeId}
-import pl.touk.nussknacker.engine.api.context.ProcessCompilationError.MissingParameters
 import pl.touk.nussknacker.engine.api.definition.{Parameter => ParameterDefinition}
 import pl.touk.nussknacker.engine.api.parameter.ParameterName
 import pl.touk.nussknacker.engine.graph.evaluatedparam.{Parameter => NodeParameter}

scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/DynamicNodeValidator.scala

@@ -5,7 +5,7 @@ import cats.data.ValidatedNel
 import cats.instances.list._
 import com.typesafe.scalalogging.LazyLogging
 import pl.touk.nussknacker.engine.{ModelData, ScenarioCompilationDependencies}
-import pl.touk.nussknacker.engine.api.{JobData, NodeId}
+import pl.touk.nussknacker.engine.api.NodeId
 import pl.touk.nussknacker.engine.api.component.ParameterConfig
 import pl.touk.nussknacker.engine.api.context._
 import pl.touk.nussknacker.engine.api.context.ProcessCompilationError.MissingParameters