Skip to content

Commit 1218b64

Browse files
committed
Use COMPILE_FLAGS for Windows VST3 module definitions
- Use MSVC-specific /D flags for compile definitions - Add _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING - This ensures definitions are applied correctly for MSVC builds https://claude.ai/code/session_01AY9chvBEmsCVjNZSUkNcbw
1 parent c786777 commit 1218b64

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

CMakeLists.txt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,14 @@ if(PLUGINVAL_VST3_VALIDATOR)
140140
elseif(WIN32)
141141
set(VST3_MODULE_WIN_FILE ${vst3sdk_SOURCE_DIR}/public.sdk/source/vst/hosting/module_win32.cpp)
142142
list(APPEND VST3ValidatorFiles ${VST3_MODULE_WIN_FILE})
143-
# Add Windows-specific compile definitions for compatibility with JUCE
144-
set_source_files_properties(${VST3_MODULE_WIN_FILE} PROPERTIES
145-
COMPILE_DEFINITIONS "NOMINMAX;WIN32_LEAN_AND_MEAN")
143+
# Add Windows-specific compile flags for compatibility
144+
if(MSVC)
145+
set_source_files_properties(${VST3_MODULE_WIN_FILE} PROPERTIES
146+
COMPILE_FLAGS "/DNOMINMAX /DWIN32_LEAN_AND_MEAN /D_SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING")
147+
else()
148+
set_source_files_properties(${VST3_MODULE_WIN_FILE} PROPERTIES
149+
COMPILE_DEFINITIONS "NOMINMAX;WIN32_LEAN_AND_MEAN;_SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING")
150+
endif()
146151
endif()
147152

148153
target_sources(pluginval PRIVATE ${VST3ValidatorFiles})

0 commit comments

Comments
 (0)