Skip to content

Commit 278ea09

Browse files
committed
Simplify OBJECT library include directories for Windows VST3 module
Use PUBLIC link to sdk_hosting to inherit its include directories automatically, and only add the minimal additional includes needed. https://claude.ai/code/session_01AY9chvBEmsCVjNZSUkNcbw
1 parent 6c1095d commit 278ea09

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

CMakeLists.txt

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,23 +145,19 @@ if(PLUGINVAL_VST3_VALIDATOR)
145145
add_library(vst3_module_win32 OBJECT
146146
${vst3sdk_SOURCE_DIR}/public.sdk/source/vst/hosting/module_win32.cpp)
147147
target_compile_features(vst3_module_win32 PRIVATE cxx_std_17)
148+
# Link to sdk_hosting to get its include directories (via PUBLIC interface)
149+
target_link_libraries(vst3_module_win32 PUBLIC sdk_hosting)
150+
# Add additional include directories needed for module_win32.cpp
148151
target_include_directories(vst3_module_win32 PRIVATE
149152
${vst3sdk_SOURCE_DIR}
150-
${vst3sdk_SOURCE_DIR}/pluginterfaces
151-
${vst3sdk_SOURCE_DIR}/base
152-
${vst3sdk_SOURCE_DIR}/public.sdk
153-
${vst3sdk_SOURCE_DIR}/public.sdk/source
154-
${vst3sdk_SOURCE_DIR}/public.sdk/source/vst
155-
${vst3sdk_SOURCE_DIR}/public.sdk/source/vst/hosting
156-
${vst3sdk_SOURCE_DIR}/public.sdk/source/vst/utility)
153+
${vst3sdk_SOURCE_DIR}/public.sdk/source/vst/hosting)
157154
target_compile_definitions(vst3_module_win32 PRIVATE
158155
NOMINMAX
159156
WIN32_LEAN_AND_MEAN
160157
_UNICODE
161158
UNICODE
162159
_CRT_SECURE_NO_WARNINGS
163160
_SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING)
164-
target_link_libraries(vst3_module_win32 PRIVATE sdk_hosting)
165161
# Set static CRT for the object library
166162
set_property(TARGET vst3_module_win32 PROPERTY
167163
MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")

0 commit comments

Comments
 (0)