Merge pull request #7 from Traction-Rec/fix/resilient-cleanup-test

fix: retry GitHub webhook delivery on 401 or missing secret

Author: JonnyPower

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "n8n-slack-unihook"
-version = "0.3.0"
+version = "0.3.1"
 edition = "2024"
 description = "A Slack event router for n8n that enables multiple workflows to share a single Slack app webhook"
 license = "MIT"
@@ -45,6 +45,8 @@ reqwest = { version = "0.13", features = ["json", "cookies"] }
 hmac = "0.12"
 sha2 = "0.10"
 hex = "0.4"
+# Mock HTTP server for unit tests
+wiremock = "0.6"
 
 [[test]]
 name = "integration"

src/n8n/client.rs

@@ -147,6 +147,7 @@ impl N8nClient {
                             events = ?trigger.events,
                             owner = %trigger.owner,
                             repository = %trigger.repository,
+                            has_webhook_secret = trigger.webhook_secret.is_some(),
                             "Found GitHub trigger"
                         );
                         triggers.push(trigger);
@@ -215,12 +216,15 @@ impl N8nClient {
     /// The `raw_body` parameter is the exact raw request body from the source
     /// (Slack, Jira, etc.). This is forwarded as-is (not re-serialized) to
     /// preserve the exact bytes for signature/authentication verification by n8n.
+    ///
+    /// Returns the HTTP status code from n8n's response on success, or an error
+    /// if the request couldn't be sent at all (connection failure, DNS, etc.).
     pub async fn forward_event(
         &self,
         webhook_url: &str,
         raw_body: &str,
         headers: &HeaderMap,
-    ) -> Result<(), N8nClientError> {
+    ) -> Result<u16, N8nClientError> {
         debug!(
             webhook_url = %webhook_url,
             forwarded_headers = headers.len(),
@@ -249,16 +253,18 @@ impl N8nClient {
             N8nClientError::RequestFailed(e.to_string())
         })?;
 
-        if !response.status().is_success() {
-            let status = response.status();
+        let status = response.status();
+        let status_code = status.as_u16();
+
+        if !status.is_success() {
             warn!(
                 status = %status,
                 webhook_url = %webhook_url,
                 "Webhook returned non-success status"
             );
         }
 
-        Ok(())
+        Ok(status_code)
     }
 }