Made an assumption (see PR) to eliminate all mypy errors

Author: Cyclic3

extensions/settings/objects/server_settings.py

@@ -10,7 +10,7 @@
 import discord
 
 from resources.utils.debug import debug, DebugColor
-from .server_attributes import ServerAttributes, GuildAttributeType
+from .server_attributes import ServerAttributes, GuildAttributeType, MessageableGuildChannel
 from .server_attribute_ids import ServerAttributeIds
 from .enabled_modules import EnabledModules
 
@@ -123,7 +123,7 @@ def is_attribute_type(val: type):
         )
         return f
 
-    funcs: set[Callable[[int], GuildAttributeType | discord.abc.PrivateChannel | None]] = set()
+    funcs: set[Callable[[int], GuildAttributeType| None]] = set()
 
     if is_attribute_type(discord.Guild):
         funcs.add(client.get_guild)
@@ -133,9 +133,10 @@ def is_attribute_type(val: type):
         #  parse if the type matches exactly.
         funcs.add(guild.get_channel_or_thread)
     if is_attribute_type(discord.abc.Messageable):
-        funcs.add(client.get_channel)
+        # There is no attribute that gives a PrivateChannel
+        funcs.add(typing.cast(Callable[[int], MessageableGuildChannel|None], client.get_channel))
     if is_attribute_type(discord.TextChannel):
-        funcs.add(client.get_channel)
+        funcs.add(typing.cast(Callable[[int], discord.TextChannel|None], client.get_channel))
     if is_attribute_type(discord.User):
         funcs.add(client.get_user)
     if is_attribute_type(discord.Role):
@@ -144,9 +145,9 @@ def is_attribute_type(val: type):
         # I think it's safe to assume the stored value was an object of
         #  the correct type in the first place. As in, it's a
         #  CategoryChannel id, not a VoiceChannel id.
-        funcs.add(client.get_channel)
+        funcs.add(typing.cast(Callable[[int], discord.CategoryChannel|None], client.get_channel))
     if is_attribute_type(discord.channel.VoiceChannel):
-        funcs.add(client.get_channel)
+        funcs.add(typing.cast(Callable[[int], discord.VoiceChannel|None], client.get_channel))
     if is_attribute_type(discord.Emoji):
         funcs.add(guild.get_emoji)
     if is_attribute_type(int):

resources/customs/bot.py

@@ -8,7 +8,7 @@
 # ^ for scheduling Reminders
 from datetime import datetime
 # ^ for startup and crash logging, and Reminders
-from typing import TYPE_CHECKING, TypeVar
+from typing import TYPE_CHECKING, TypeVar, reveal_type, cast
 import motor.core as motorcore  # for typing
 from pymongo.database import Database as PyMongoDatabase
 # ^ for MongoDB database typing
@@ -28,7 +28,7 @@
 
 T = TypeVar('T')
 G = TypeVar('G')
-
+type GetGuildAttributeReturn[T] = GuildAttributeType | T | None | list["GetGuildAttributeReturn"[T]]
 
 class Bot(commands.Bot):
     # bot uptime start, used in /version in cmd_staffaddons
@@ -132,7 +132,7 @@ def get_guild_attribute(
             guild: discord.Guild | int,
             *args: str,
             default: T | None = None
-    ) -> GuildAttributeType | T | None | list[GuildAttributeType | T | None]:
+    ) -> GetGuildAttributeReturn[T]:
         """
         Get ServerSettings attributes for the given guild.
 
@@ -161,12 +161,12 @@ def get_guild_attribute(
             #  doesn't have any settings (perhaps the bot was recently
             #  added).
             if len(args) > 1:
-                return [default for _ in args]
+                return [cast(GetGuildAttributeReturn[T], default) for _ in args]
             return default
 
         attributes = self.server_settings[guild_id].attributes
 
-        output: list[GuildAttributeType | T] = []
+        output: list[GetGuildAttributeReturn[T]] = []
 
         parent_server = attributes[AttributeKeys.parent_server]  # type: ignore[literal-required]