Skip to content

Improve OperationOutput to make it less likely to miss .messages? #87

@MarijnS95

Description

@MarijnS95

#80

As a followup, we were thinking about rewriting OperationOutput to an enum which effectively forces matching and make it less easy to miss the .messages field containing compiler warnings (than the current let shader = compile()?.blob;).

This however meant removing Result<> from most types if the enum in question is going to contain its own OperationResult::Failed (note renaming OperationOutput back to OperationResult), which is not a Result and does not play well with ?, causing lots of code churn to map & return things.

If someone has a good idea to make this API both explicit and hassle-free (👀) I'm all ears.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions