Skip to content

Commit e28d4f7

Browse files
author
Travis Lawrence
committed
Add about and title change
1 parent 60bbfe8 commit e28d4f7

6 files changed

Lines changed: 50 additions & 17 deletions

File tree

client/options.html

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<body>
77
<div class='apod-options'>
8-
<h3>APOD By The Trav Options</h3>
8+
<h3>Options</h3>
99
<form id='apod-options'>
1010

1111
<div class='option'>
@@ -37,6 +37,15 @@ <h3>APOD By The Trav Options</h3>
3737
</div>
3838
</div>
3939
</form>
40+
<div class='about-apod'>
41+
<p>APOD By The Trav</p>
42+
<ul>
43+
<li><a target='_blank' href='https://www.redundantrobot.com'>RedundantRobot</a></li>
44+
<li><a target='_blank' href='https://www.github.com/travisl12'>Github</a></li>
45+
<li><a target='_blank' href='https://www.twitter.com/travisl12'>Twitter</a></li>
46+
<li><a target='_blank' href='https://codepen.io/TravisL12'>CodePen</a></li>
47+
</ul>
48+
</div>
4049
</div>
4150
</body>
4251
</html>

client/scripts/components/Apod.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,7 @@ class Apod {
312312
}
313313

314314
constructApod() {
315+
document.title = `${this.response.title} - (${this.history.currentIdx + 1})`;
315316
apodTitle.textContent = this.response.title;
316317
apodDate.textContent = DateManager.prettyDateFormat(this.response.date);
317318
this.wouldYouLikeToKnowMore(`${this.response.title} ${this.response.explanation}`);

client/styles/_variables.scss

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,5 +65,19 @@ $highlight-blue: lightblue;
6565
transform-origin: bottom;
6666
}
6767

68+
h1 {
69+
font-size: 24px;
70+
}
71+
72+
h2 {
73+
font-size: 18px;
74+
}
75+
76+
ul, li {
77+
margin: 0;
78+
padding: 0;
79+
display: inline-block;
80+
}
81+
6882
@import 'apod_loading_sun';
6983
@import 'apod_loading_moon';

client/styles/options.scss

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,30 @@ body {
1717
font-size: 14px;
1818
margin-top: 0;
1919
}
20+
.about-apod {
21+
padding: 10px;
22+
width: 100%;
23+
box-sizing: border-box;
24+
background-color: lightgray;
25+
p {
26+
font-weight: bold;
27+
margin-top: 0;
28+
text-align: center;
29+
}
30+
31+
ul {
32+
display: flex;
33+
justify-content: space-between;
34+
}
2035

36+
a {
37+
color: $gray;
38+
text-decoration: none;
39+
&:hover {
40+
text-decoration: underline;
41+
}
42+
}
43+
}
2144
#apod-options {
2245

2346
.option {

client/styles/style.scss

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,6 @@
1919
background-repeat: no-repeat;
2020
}
2121

22-
h1 {
23-
font-size: 24px;
24-
}
25-
26-
h2 {
27-
font-size: 18px;
28-
}
29-
3022
body {
3123
background: black;
3224
margin: 0;
@@ -35,12 +27,6 @@ body {
3527
height: 100%;
3628
}
3729

38-
ul, li {
39-
margin: 0;
40-
padding: 0;
41-
display: inline-block;
42-
}
43-
4430
.bg-contain {
4531
background-size: contain;
4632
}

webpack.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const path = require('path');
33
const HtmlWebpackPlugin = require('html-webpack-plugin');
44
const CopyWebpackPlugin = require('copy-webpack-plugin');
55
const ExtractTextPlugin = require('extract-text-webpack-plugin');
6-
// const Uglify = require('uglifyjs-webpack-plugin');
6+
const Uglify = require('uglifyjs-webpack-plugin');
77

88
const IndexHtmlWebpackPluginConfig = new HtmlWebpackPlugin({
99
template: './client/apod-by-trav.html',
@@ -72,7 +72,7 @@ module.exports = {
7272
],
7373
},
7474
plugins: [
75-
// new Uglify(),
75+
new Uglify(),
7676
IndexHtmlWebpackPluginConfig,
7777
OptionsHtmlWebpackPluginConfig,
7878
CopyWebpackPluginConfig,

0 commit comments

Comments
 (0)