fix: Update Trilium repository URL and image to v0.100.0#12
Conversation
Summary of ChangesHello @kalbasit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Trilium Helm chart to align with recent changes in the upstream Trilium project. It ensures the chart references the correct repository and image names, while also bringing the application version up to the latest Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Trilium repository URL and image version. The changes in values.yaml properly set the image to triliumnext/trilium:v0.100.0, and removing the hardcoded image from release.yaml is a good practice.
However, for the chart to be fully consistent with this update, a couple of important changes are missing in charts/trilium/Chart.yaml:
appVersionMismatch: TheappVersionis still0.92.4. It should be updated to0.100.0to reflect the actual application version being deployed. This is crucial for correct chart metadata.- Incorrect
sourcesURL: In thesourceslist, the URLhhttps://github.com/TriliumNext/Notesis both outdated and contains a typo (hhttps). It should be corrected tohttps://github.com/TriliumNext/Trilium. - (Optional) Update description: For consistency with the repository rename, you might also want to update the
descriptionwhich still refers to "Trilium Notes".
Applying these fixes will ensure the chart is accurate and provides a clear experience for users.
Updated Trilium repository references and upgraded to the latest version. - Updated the maintainer URL from `https://github.com/TriliumNext/Notes` to `https://github.com/TriliumNext/Trilium` - Changed the image repository from `triliumnext/notes` to `triliumnext/trilium` - Upgraded the image tag from `v0.92.4` to `v0.100.0` - Removed duplicate image configuration from the release.yaml template
acc1529 to
5890493
Compare
Updated Trilium repository references and upgraded to the latest version.
https://github.com/TriliumNext/Notestohttps://github.com/TriliumNext/Triliumtriliumnext/notestotriliumnext/triliumv0.92.4tov0.100.0