feat(engine,sql): add BattlePay in-game shop with purchase flow and Shop Points currency

Author: fIyingPhoenix

sql/updates/auth/master/2026_08_13_00_auth.sql

@@ -0,0 +1,19 @@
+-- See ARGUSCORE_FIXES.md for details.
+
+-- BattlePay Phase 2: account-wide Shop Points balance, lazily created (INSERT ... ON DUPLICATE KEY
+-- UPDATE) on first credit rather than pre-populated for every account.
+--
+-- No in-server crediting queue/poller exists for this table on purpose - any external site with its
+-- own database access should write to this table directly, e.g.:
+--   INSERT INTO battlepay_account_balance (BattlenetAccountId, Balance) VALUES (?, ?)
+--     ON DUPLICATE KEY UPDATE Balance = Balance + VALUES(Balance);
+-- (safe to call repeatedly - no separate "does a row exist yet" check needed). Still deliberately
+-- NOT a webhook/HTTP endpoint on this server (security preference: no new network-facing surface) -
+-- the external site's own code/database access is the only integration point.
+CREATE TABLE IF NOT EXISTS `battlepay_account_balance` (
+  `BattlenetAccountId` INT UNSIGNED NOT NULL,
+  `Balance` BIGINT UNSIGNED NOT NULL DEFAULT 0,
+  `UpdatedAt` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
+  PRIMARY KEY (`BattlenetAccountId`),
+  CONSTRAINT `fk_bpay_balance_bnet` FOREIGN KEY (`BattlenetAccountId`) REFERENCES `battlenet_accounts` (`id`) ON DELETE CASCADE
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci COMMENT='BattlePay: account-wide Shop Points balance';

sql/updates/characters/master/2026_08_13_00_characters.sql

@@ -0,0 +1,28 @@
+-- See ARGUSCORE_FIXES.md for details.
+
+-- BattlePay Phase 2: per-purchase audit trail. Realm-local (characters DB, not world/auth) because
+-- delivery (bags/mailbox) is realm-local, even though the Shop Points balance itself is account-wide
+-- (auth DB). DeliveryState is the crash-recovery ledger for the deliver-then-deduct purchase flow:
+-- 0 = delivered, balance not yet deducted (should always resolve to 1 within the same transaction
+--     chain - a row stuck at 0 indicates the server died mid-purchase; nothing to reconcile, since
+--     delivery and this row are written in the same characters-DB transaction)
+-- 1 = delivered and paid for (the normal end state)
+-- 2 = delivered but the balance deduction failed (a race with a concurrent external credit-queue
+--     change reduced the balance between the initial check and the deduct) - the server "ate" the
+--     cost rather than risk taking currency without delivering; flagged for admin reconciliation.
+CREATE TABLE IF NOT EXISTS `battlepay_purchase_log` (
+  `Id` BIGINT UNSIGNED NOT NULL AUTO_INCREMENT,
+  `BattlenetAccountId` INT UNSIGNED NOT NULL,
+  `AccountId` INT UNSIGNED NOT NULL COMMENT 'game account (WorldSession::GetAccountId)',
+  `CharacterGuid` BIGINT UNSIGNED NOT NULL DEFAULT 0 COMMENT 'ObjectGuid::LowType is uint64 - 0 if delivered by mail to an offline TargetCharacter whose guid was only known from the client packet',
+  `ProductID` INT UNSIGNED NOT NULL,
+  `PurchaseID` BIGINT UNSIGNED NOT NULL COMMENT 'BattlePayMgr-generated id, unique - used to update DeliveryState later without needing the AUTO_INCREMENT Id back across an async transaction boundary',
+  `PricePaid` BIGINT UNSIGNED NOT NULL COMMENT 'Shop Points, denormalized at purchase time so later price changes do not rewrite history',
+  `DeliveryState` TINYINT UNSIGNED NOT NULL DEFAULT 0,
+  `CreatedAt` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
+  PRIMARY KEY (`Id`),
+  UNIQUE KEY `uk_purchase_id` (`PurchaseID`),
+  KEY `idx_character` (`CharacterGuid`),
+  KEY `idx_bnet_account` (`BattlenetAccountId`),
+  KEY `idx_delivery_state` (`DeliveryState`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci COMMENT='BattlePay: per-purchase audit trail';

sql/updates/world/master/2026_08_13_13_world.sql

@@ -0,0 +1,127 @@
+-- See ARGUSCORE_FIXES.md for details.
+
+CREATE TABLE IF NOT EXISTS `battlepay_display_info` (
+  `DisplayInfoId` INT UNSIGNED NOT NULL,
+  `CreatureDisplayInfoID` INT UNSIGNED NOT NULL DEFAULT 0,
+  `FileDataID` INT UNSIGNED NOT NULL DEFAULT 0,
+  `Flags` INT UNSIGNED NOT NULL DEFAULT 0,
+  `Name1` VARCHAR(128) NOT NULL DEFAULT '',
+  `Name2` VARCHAR(128) NOT NULL DEFAULT '',
+  `Name3` VARCHAR(128) NOT NULL DEFAULT '',
+  `Name4` VARCHAR(128) NOT NULL DEFAULT '',
+  PRIMARY KEY (`DisplayInfoId`)
+);
+
+CREATE TABLE IF NOT EXISTS `battlepay_display_info_locales` (
+  `Id` INT UNSIGNED NOT NULL,
+  `Locale` VARCHAR(4) NOT NULL,
+  `Name1` VARCHAR(128) NULL,
+  `Name2` VARCHAR(128) NULL,
+  `Name3` VARCHAR(128) NULL,
+  `Name4` VARCHAR(128) NULL,
+  PRIMARY KEY (`Id`, `Locale`)
+);
+
+CREATE TABLE IF NOT EXISTS `battlepay_display_info_visuals` (
+  `DisplayInfoId` INT UNSIGNED NOT NULL,
+  `DisplayId` INT UNSIGNED NOT NULL DEFAULT 0,
+  `VisualId` INT UNSIGNED NOT NULL DEFAULT 0,
+  `ProductName` VARCHAR(128) NOT NULL DEFAULT '',
+  PRIMARY KEY (`DisplayInfoId`, `DisplayId`)
+);
+
+CREATE TABLE IF NOT EXISTS `battlepay_product` (
+  `ProductID` INT UNSIGNED NOT NULL,
+  `Type` TINYINT UNSIGNED NOT NULL DEFAULT 0,
+  `ChoiceType` TINYINT UNSIGNED NOT NULL DEFAULT 0,
+  `Flags` INT UNSIGNED NOT NULL DEFAULT 0,
+  `DisplayInfoID` INT UNSIGNED NOT NULL DEFAULT 0,
+  `ScriptName` VARCHAR(64) NOT NULL DEFAULT '',
+  `ClassMask` INT UNSIGNED NOT NULL DEFAULT 0,
+  `WebsiteType` TINYINT UNSIGNED NOT NULL DEFAULT 0,
+  -- Fix vs. reference: reference's CustomValue is declared but never populated from any DB
+  -- column, silently breaking Gold/Level delivery. Here it's a real, loaded column.
+  `CustomValue` INT UNSIGNED NOT NULL DEFAULT 0,
+  -- Deviation from reference: three independent prices (0 = not offered via that currency)
+  -- replace the reference's single NormalPriceFixedPoint/CurrentPriceFixedPoint, so a player can
+  -- pay with Gold, Vote Points, or Donate Points.
+  `GoldPrice` BIGINT UNSIGNED NOT NULL DEFAULT 0,
+  `VotePointsPrice` INT UNSIGNED NOT NULL DEFAULT 0,
+  `DonatePointsPrice` INT UNSIGNED NOT NULL DEFAULT 0,
+  PRIMARY KEY (`ProductID`)
+);
+
+CREATE TABLE IF NOT EXISTS `battlepay_product_item` (
+  `ID` INT UNSIGNED NOT NULL AUTO_INCREMENT,
+  `ProductID` INT UNSIGNED NOT NULL,
+  `ItemID` INT UNSIGNED NOT NULL DEFAULT 0,
+  `Quantity` INT UNSIGNED NOT NULL DEFAULT 1,
+  `DisplayID` INT UNSIGNED NOT NULL DEFAULT 0,
+  `PetResult` INT UNSIGNED NOT NULL DEFAULT 0,
+  PRIMARY KEY (`ID`),
+  INDEX `idx_product` (`ProductID`)
+);
+
+CREATE TABLE IF NOT EXISTS `battlepay_product_group` (
+  -- NOTE: GroupID = 22 is CLIENT-HARDCODED as the Services/character-boost tab. Never assign it
+  -- to other content.
+  `GroupID` INT UNSIGNED NOT NULL,
+  `Name` VARCHAR(64) NOT NULL DEFAULT '',
+  `IconFileDataID` INT UNSIGNED NOT NULL DEFAULT 0,
+  `DisplayType` TINYINT UNSIGNED NOT NULL DEFAULT 0,
+  `Ordering` SMALLINT NOT NULL DEFAULT 0,
+  PRIMARY KEY (`GroupID`)
+);
+
+CREATE TABLE IF NOT EXISTS `battlepay_product_group_locales` (
+  `Id` INT UNSIGNED NOT NULL,
+  `Locale` VARCHAR(4) NOT NULL,
+  `Name` VARCHAR(64) NULL,
+  PRIMARY KEY (`Id`, `Locale`)
+);
+
+CREATE TABLE IF NOT EXISTS `battlepay_shop_entry` (
+  `EntryID` INT UNSIGNED NOT NULL AUTO_INCREMENT,
+  `GroupID` INT UNSIGNED NOT NULL,
+  `ProductID` INT UNSIGNED NOT NULL,
+  `Ordering` SMALLINT NOT NULL DEFAULT 0,
+  `Flags` INT UNSIGNED NOT NULL DEFAULT 0,
+  `BannerType` TINYINT UNSIGNED NOT NULL DEFAULT 0,
+  `DisplayInfoID` INT UNSIGNED NOT NULL DEFAULT 0,
+  PRIMARY KEY (`EntryID`),
+  INDEX `idx_group` (`GroupID`),
+  INDEX `idx_product` (`ProductID`)
+);
+
+-- Seed data: a couple of real, verified Legion items (confirmed present in this build's
+-- ItemSparse.csv export) for Phase 1 verification (product list display only, not purchasable
+-- yet - the purchase flow is added in a later phase).
+
+DELETE FROM `battlepay_product_group` WHERE `GroupID` IN (1, 10);
+INSERT INTO `battlepay_product_group` (`GroupID`, `Name`, `IconFileDataID`, `DisplayType`, `Ordering`) VALUES
+(1, 'Mounts', 132261, 0, 0),
+(10, 'Toys', 237429, 0, 1);
+
+DELETE FROM `battlepay_display_info` WHERE `DisplayInfoId` IN (1, 2, 3);
+INSERT INTO `battlepay_display_info` (`DisplayInfoId`, `Name1`, `Name3`) VALUES
+(1, 'Jeweled Onyx Panther', 'A shimmering onyx panther mount.'),
+(2, 'Reins of the Grove Warden', 'A loyal warden of the grove, ready to carry you into battle.'),
+(3, 'Snowball', 'Throw it at a friend.');
+
+DELETE FROM `battlepay_product` WHERE `ProductID` IN (1, 2, 3);
+INSERT INTO `battlepay_product` (`ProductID`, `Type`, `WebsiteType`, `DisplayInfoID`, `GoldPrice`, `VotePointsPrice`, `DonatePointsPrice`) VALUES
+(1, 0, 21, 1, 0,        50,  0),   -- Jeweled Onyx Panther - Vote Points only
+(2, 0, 21, 2, 500000,   0,   250), -- Reins of the Grove Warden - Gold or Donate Points
+(3, 0, 3,  3, 1000,     5,   0);   -- Snowball - Gold or Vote Points
+
+DELETE FROM `battlepay_product_item` WHERE `ProductID` IN (1, 2, 3);
+INSERT INTO `battlepay_product_item` (`ProductID`, `ItemID`, `Quantity`) VALUES
+(1, 82453, 1),
+(2, 128422, 1),
+(3, 17202, 5);
+
+DELETE FROM `battlepay_shop_entry` WHERE `ProductID` IN (1, 2, 3);
+INSERT INTO `battlepay_shop_entry` (`GroupID`, `ProductID`, `Ordering`) VALUES
+(1, 1, 0),
+(1, 2, 1),
+(10, 3, 0);

sql/updates/world/master/2026_08_13_14_world.sql

@@ -0,0 +1,22 @@
+-- See ARGUSCORE_FIXES.md for details.
+
+-- Phase 2: collapse the 3-currency pricing model (GoldPrice/VotePointsPrice/DonatePointsPrice) into
+-- a single account-wide Shop Points price. The real 7.3.5 client purchase flow
+-- (C_StoreSecure.PurchaseProduct/PurchaseProductConfirm) has no currency-selector field at all, so
+-- per-purchase currency choice was never actually possible through the native Store UI.
+
+-- Plain ADD/DROP COLUMN (no IF [NOT] EXISTS) - that clause isn't reliably supported across the
+-- MySQL/MariaDB versions this might run against. The DB updater tool tracks applied migrations
+-- itself and won't re-run this file under normal use, so idempotency here isn't required the way
+-- it is for files sometimes applied directly via a raw mysql client.
+ALTER TABLE `battlepay_product`
+  ADD COLUMN `ShopPointsPrice` BIGINT UNSIGNED NOT NULL DEFAULT 0 AFTER `CustomValue`;
+
+UPDATE `battlepay_product` SET `ShopPointsPrice` = 500  WHERE `ProductID` = 1; -- Jeweled Onyx Panther
+UPDATE `battlepay_product` SET `ShopPointsPrice` = 1000 WHERE `ProductID` = 2; -- Reins of the Grove Warden
+UPDATE `battlepay_product` SET `ShopPointsPrice` = 50   WHERE `ProductID` = 3; -- Snowball
+
+ALTER TABLE `battlepay_product`
+  DROP COLUMN `GoldPrice`,
+  DROP COLUMN `VotePointsPrice`,
+  DROP COLUMN `DonatePointsPrice`;

sql/updates/world/master/2026_08_14_00_world.sql

@@ -0,0 +1,23 @@
+-- See ARGUSCORE_FIXES.md for details.
+
+-- BattlePay: real icons + 3D "View in 3D" preview for the 3 seeded shop products. The original
+-- Phase 1 seed left `battlepay_display_info.FileDataID` at its default (0), so the client fell back
+-- to the placeholder "?" icon for every tile, and left `battlepay_display_info_visuals` empty, so no
+-- product ever had a 3D model card to show.
+--
+-- FileDataID values are each item's own icon, read directly from Item.db2 (`IconFileDataID` column,
+-- keyed by ItemID - logs/db2csv/Item.csv), not guessed. DisplayId/VisualId values for the two mounts
+-- are each mount's CreatureDisplayInfoID (from MountXDisplay.csv, keyed by MountID) and UiModelSceneID
+-- (from Mount.csv, keyed by the item's on-use SpellID from ItemEffect.csv) - the same chain the real
+-- client walks (Item -> on-use Spell -> Mount -> MountXDisplay) to know what to render when the mount
+-- is actually summoned. Snowball (a thrown consumable, not a mount) intentionally gets an icon only,
+-- no Visuals row - matches how the real Shop displays non-mount items.
+
+UPDATE `battlepay_display_info` SET `FileDataID` = 603364  WHERE `DisplayInfoId` = 1; -- Jeweled Onyx Panther (ItemID 82453)
+UPDATE `battlepay_display_info` SET `FileDataID` = 1129627 WHERE `DisplayInfoId` = 2; -- Reins of the Grove Warden (ItemID 128422)
+UPDATE `battlepay_display_info` SET `FileDataID` = 132387  WHERE `DisplayInfoId` = 3; -- Snowball (ItemID 17202)
+
+DELETE FROM `battlepay_display_info_visuals` WHERE `DisplayInfoId` IN (1, 2);
+INSERT INTO `battlepay_display_info_visuals` (`DisplayInfoId`, `DisplayId`, `VisualId`, `ProductName`) VALUES
+(1, 42185, 4, 'Jeweled Onyx Panther'), -- Mount ID 451, CreatureDisplayInfoID 42185, UiModelSceneID 4
+(2, 64583, 4, 'Reins of the Grove Warden'); -- Mount ID 764, CreatureDisplayInfoID 64583, UiModelSceneID 4

sql/updates/world/master/2026_08_14_01_world.sql

@@ -0,0 +1,16 @@
+-- See ARGUSCORE_FIXES.md for details.
+
+-- BattlePay: the original Phase 1 seed for `battlepay_shop_entry` never set `DisplayInfoID` (column
+-- exists, just wasn't in the INSERT's column list), so it stayed at its default 0 for all 3 rows.
+-- `BattlePayMgr::SendProductList()` builds the "Shop" array (WorldPackets::BattlePay::
+-- BattlePayShopEntry) from this table, and calls WriteDisplayInfo(entry.DisplayInfoID, ...)
+-- independently of the "ProductInfo"/"Product" arrays (which use battlepay_product.DisplayInfoID,
+-- already correct) - with DisplayInfoID=0, WriteDisplayInfo always returns "no display info" for the
+-- Shop array specifically, regardless of the icon/model fix in 2026_08_14_00_world.sql. If the
+-- client's product-tile grid renders from this Shop array (suspected but not proven), its per-entry
+-- DisplayInfo would always have been empty. Filling it in with the same DisplayInfoId already used by
+-- each row's product, to close this gap alongside the earlier icon/model fix.
+
+UPDATE `battlepay_shop_entry` SET `DisplayInfoID` = 1 WHERE `ProductID` = 1; -- Jeweled Onyx Panther
+UPDATE `battlepay_shop_entry` SET `DisplayInfoID` = 2 WHERE `ProductID` = 2; -- Reins of the Grove Warden
+UPDATE `battlepay_shop_entry` SET `DisplayInfoID` = 3 WHERE `ProductID` = 3; -- Snowball

sql/updates/world/master/2026_08_14_02_world.sql

@@ -0,0 +1,8 @@
+-- See ARGUSCORE_FIXES.md for details.
+
+-- Emergency revert of 2026_08_14_01_world.sql: populating battlepay_shop_entry.DisplayInfoID caused
+-- the real client to fail with "Not enough memory" (Battle.net support article 6926) - a much worse
+-- regression than the icon/3D-model issue it was meant to fix. Reverting immediately; see
+-- ARGUSCORE_FIXES.md "Follow-up 5" for the investigation.
+
+UPDATE `battlepay_shop_entry` SET `DisplayInfoID` = 0 WHERE `ProductID` IN (1, 2, 3);

src/server/database/Database/Implementation/CharacterDatabase.cpp

@@ -723,6 +723,10 @@ void CharacterDatabaseConnection::DoPrepareStatements()
     PrepareStatement(CHAR_UPD_CHARACTER_INSTANCE_LOCK_FORCE_EXPIRE, "UPDATE character_instance_lock SET expiryTime = ?, extended = 0 WHERE guid = ? AND mapId = ? AND lockId = ?", CONNECTION_ASYNC);
     PrepareStatement(CHAR_DEL_INSTANCE, "DELETE FROM instance WHERE instanceId = ?", CONNECTION_ASYNC);
     PrepareStatement(CHAR_INS_INSTANCE, "INSERT INTO instance (instanceId, data, completedEncountersMask, entranceWorldSafeLocId) VALUES (?, ?, ?, ?)", CONNECTION_ASYNC);
+
+    // BattlePay Shop Points - see ARGUSCORE_FIXES.md
+    PrepareStatement(CHAR_INS_BATTLEPAY_PURCHASE_LOG, "INSERT INTO battlepay_purchase_log (BattlenetAccountId, AccountId, CharacterGuid, ProductID, PurchaseID, PricePaid, DeliveryState) VALUES (?, ?, ?, ?, ?, ?, ?)", CONNECTION_ASYNC);
+    PrepareStatement(CHAR_UPD_BATTLEPAY_PURCHASE_LOG_STATE, "UPDATE battlepay_purchase_log SET DeliveryState = ? WHERE PurchaseID = ?", CONNECTION_ASYNC);
 }
 
 CharacterDatabaseConnection::CharacterDatabaseConnection(MySQLConnectionInfo& connInfo, ConnectionFlags connectionFlags) : MySQLConnection(connInfo, connectionFlags)

src/server/database/Database/Implementation/CharacterDatabase.h

@@ -606,6 +606,10 @@ enum CharacterDatabaseStatements : uint32
     CHAR_DEL_INSTANCE,
     CHAR_INS_INSTANCE,
 
+    // BattlePay Shop Points - see ARGUSCORE_FIXES.md
+    CHAR_INS_BATTLEPAY_PURCHASE_LOG,
+    CHAR_UPD_BATTLEPAY_PURCHASE_LOG_STATE,
+
     MAX_CHARACTERDATABASE_STATEMENTS
 };
 

src/server/database/Database/Implementation/LoginDatabase.cpp

@@ -188,6 +188,20 @@ void LoginDatabaseConnection::DoPrepareStatements()
     PrepareStatement(LOGIN_SEL_BNET_ITEM_FAVORITE_APPEARANCES, "SELECT itemModifiedAppearanceId FROM battlenet_item_favorite_appearances WHERE battlenetAccountId = ?", CONNECTION_ASYNC);
     PrepareStatement(LOGIN_INS_BNET_ITEM_FAVORITE_APPEARANCE, "INSERT INTO battlenet_item_favorite_appearances (battlenetAccountId, itemModifiedAppearanceId) VALUES (?, ?)", CONNECTION_ASYNC);
     PrepareStatement(LOGIN_DEL_BNET_ITEM_FAVORITE_APPEARANCE, "DELETE FROM battlenet_item_favorite_appearances WHERE battlenetAccountId = ? AND itemModifiedAppearanceId = ?", CONNECTION_ASYNC);
+
+    // BattlePay Shop Points - see ARGUSCORE_FIXES.md
+    PrepareStatement(LOGIN_SEL_BATTLEPAY_BALANCE, "SELECT Balance FROM battlepay_account_balance WHERE BattlenetAccountId = ?", CONNECTION_ASYNC);
+    // No "AND Balance >= ?" guard needed - Balance is BIGINT UNSIGNED and the server runs with
+    // sql_mode=STRICT_TRANS_TABLES, so an UPDATE that would underflow it errors out (caught via the
+    // standard AsyncCommitTransaction().AfterComplete(bool success) pattern) rather than wrapping or
+    // going negative.
+    PrepareStatement(LOGIN_UPD_BATTLEPAY_BALANCE_DEDUCT, "UPDATE battlepay_account_balance SET Balance = Balance - ? WHERE BattlenetAccountId = ?", CONNECTION_ASYNC);
+    // Also the exact statement an external site's own code can mirror to credit a balance directly
+    // (INSERT ... ON DUPLICATE KEY UPDATE Balance = Balance + ? - safe to call repeatedly, no
+    // separate "does a row exist yet" check needed).
+    PrepareStatement(LOGIN_INS_BATTLEPAY_BALANCE_CREDIT, "INSERT INTO battlepay_account_balance (BattlenetAccountId, Balance) VALUES (?, ?) "
+        "ON DUPLICATE KEY UPDATE Balance = Balance + VALUES(Balance)", CONNECTION_BOTH);
+    PrepareStatement(LOGIN_SEL_BATTLENET_ACCOUNT_BY_ACCOUNT_ID, "SELECT battlenet_account FROM account WHERE id = ?", CONNECTION_SYNCH);
 }
 
 LoginDatabaseConnection::LoginDatabaseConnection(MySQLConnectionInfo& connInfo, ConnectionFlags connectionFlags) : MySQLConnection(connInfo, connectionFlags)