Skip to content

MantaHTTPSuite needs updating for new router #10

Description

@tgross

Much like as in an issue with gomanta the test suite was not updated with the new router that was added in f676d62. So currently the tests fail for what are problems with our test harness rather than the library.

go test ./...
# github.com/joyent/gocommon/testing_test
testing/httpsuite_test.go:40: not enough arguments in call to s.HTTPSuite.Mux.Handle
testing/httpsuite_test.go:52: not enough arguments in call to s.HTTPSuite.Mux.Handle
# github.com/joyent/gocommon/http
http/client_test.go:78: s.HTTPSuite.Mux.HandleFunc undefined (type *httprouter.Router has no field or method HandleFunc)
ok      github.com/joyent/gocommon      0.010s
ok      github.com/joyent/gocommon/client       0.926s
ok      github.com/joyent/gocommon/errors       0.007s
FAIL    github.com/joyent/gocommon/http [build failed]
?       github.com/joyent/gocommon/jpc  [no test files]
FAIL    github.com/joyent/gocommon/testing [build failed]

I'll fix this up.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions