cleanups to satisfy 'make check'

Author: nshalman

Makefile

@@ -5,7 +5,7 @@
 #
 
 #
-# Copyright 2024 MNX Cloud, Inc.
+# Copyright 2025 MNX Cloud, Inc.
 #
 
 NAME = smartos-ui
@@ -190,3 +190,9 @@ include ./deps/eng/tools/mk/Makefile.deps
 include ./deps/eng/tools/mk/Makefile.targ
 include ./deps/eng/tools/mk/Makefile.rust.targ
 
+.PHONY: world
+world: $(TOP)/tools/uiadm.sh
+
+.PHONY: install
+install: $(TOP)/tools/uiadm.sh
+	cp -p $< $(DESTDIR)/sbin/uiadm

executor/src/endpoints/image.rs

@@ -5,7 +5,7 @@
  */
 
 /*
- * Copyright 2024 MNX Cloud, Inc.
+ * Copyright 2025 MNX Cloud, Inc.
  */
 
 use std::process::Stdio;
@@ -186,7 +186,7 @@ pub async fn post_import_by_id(
         return Err(to_internal_error("Unable to get image import queue"));
     }
 
-    let args = ["import", "-q", "-S", &req.url.as_ref(), &id.to_string()];
+    let args = ["import", "-q", "-S", req.url.as_ref(), &id.to_string()];
     debug!(ctx.log, "Executing imgadm {:?}", &args);
     let out = Command::new("imgadm")
         .args(args)

shared/src/image.rs

@@ -268,13 +268,13 @@ impl Image {
     /// Helper for determining if we should offer the option of setting a
     /// root_pw for an image
     pub fn has_root_user(&self) -> bool {
-        return match &self.manifest.r#type {
+        match &self.manifest.r#type {
             Type::ZVol => match &self.manifest.users {
                 Some(users) => users.iter().any(|user| user.name == "root"),
                 None => true,
             },
             _ => false,
-        };
+        }
     }
 
     /// Helper for determining if we should set the bootrom to uefi