fix: resolve golangci-lint issues

- Add error handling for resp.Body.Close() in client.go
- Fix gofmt formatting in main.go
- Optimize regexp compilation in resource_user_test.go
- Remove unnecessary type assertion in metadata_test.go
- Remove unused test functions in resource_client_test.go

Author: Trozz

internal/client/client.go

@@ -213,7 +213,13 @@ func (c *Client) doSingleRequest(ctx context.Context, method, endpoint string, b
 		})
 		return nil, fmt.Errorf("error making request: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if err := resp.Body.Close(); err != nil {
+			tflog.Warn(ctx, "Failed to close response body", map[string]interface{}{
+				"error": err.Error(),
+			})
+		}
+	}()
 
 	respBody, err := io.ReadAll(resp.Body)
 	if err != nil {

internal/provider/resource_client_test.go

@@ -9,7 +9,6 @@ import (
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
-	"github.com/hashicorp/terraform-plugin-testing/terraform"
 )
 
 func TestAccResourceClient_basic(t *testing.T) {
@@ -179,7 +178,7 @@ func TestAccResourceClient_emptyName(t *testing.T) {
 // Test configuration functions
 
 func testAccResourceClientConfig_basic(name, callbackURL string) string {
-	return fmt.Sprintf(`
+	return testAccProviderConfig() + fmt.Sprintf(`
 resource "pocketid_client" "test" {
   name          = %[1]q
   callback_urls = [%[2]q]
@@ -188,7 +187,7 @@ resource "pocketid_client" "test" {
 }
 
 func testAccResourceClientConfig_public(name string) string {
-	return fmt.Sprintf(`
+	return testAccProviderConfig() + fmt.Sprintf(`
 resource "pocketid_client" "test" {
   name          = %[1]q
   callback_urls = ["https://example.com/callback"]
@@ -267,34 +266,3 @@ resource "pocketid_client" "test" {
 }
 
 // Test helper functions
-
-func testAccCheckClientExists(resourceName string) resource.TestCheckFunc {
-	return func(s *terraform.State) error {
-		rs, ok := s.RootModule().Resources[resourceName]
-		if !ok {
-			return fmt.Errorf("Not found: %s", resourceName)
-		}
-
-		if rs.Primary.ID == "" {
-			return fmt.Errorf("No Client ID is set")
-		}
-
-		// Here you would typically check if the client exists in the API
-		// For now, we just verify the ID is set
-		return nil
-	}
-}
-
-func testAccCheckClientDestroy(s *terraform.State) error {
-	// This function should check that all clients have been destroyed
-	for _, rs := range s.RootModule().Resources {
-		if rs.Type != "pocketid_client" {
-			continue
-		}
-
-		// Here you would typically check if the client still exists in the API
-		// and return an error if it does
-	}
-
-	return nil
-}

internal/provider/resource_user_test.go

@@ -126,8 +126,9 @@ func testAccCheckUserGroupsSet(resourceName string) resource.TestCheckFunc {
 		// Get all group attributes
 		groupCount := 0
 		groups := make(map[string]bool)
+		groupsRegex := regexp.MustCompile(`^groups\.\d+$`)
 		for key, value := range rs.Primary.Attributes {
-			if matched, _ := regexp.MatchString(`^groups\.\d+$`, key); matched {
+			if groupsRegex.MatchString(key) {
 				groups[value] = true
 				groupCount++
 			}

internal/resources/metadata_test.go

@@ -255,12 +255,10 @@ func TestResources_Interfaces(t *testing.T) {
 		t.Run(rf.name, func(t *testing.T) {
 			res := rf.factory()
 
-			// Check implements Resource interface
-			_, ok := res.(resource.Resource)
-			assert.True(t, ok, "%s should implement resource.Resource", rf.name)
+			// res is already of type resource.Resource, no need to check
 
 			// Check implements ResourceWithConfigure
-			_, ok = res.(resource.ResourceWithConfigure)
+			_, ok := res.(resource.ResourceWithConfigure)
 			assert.True(t, ok, "%s should implement resource.ResourceWithConfigure", rf.name)
 
 			// Check implements ResourceWithImportState

main.go

@@ -6,6 +6,7 @@ import (
 	"log"
 
 	"github.com/hashicorp/terraform-plugin-framework/providerserver"
+
 	"github.com/Trozz/terraform-provider-pocketid/internal/provider"
 )