Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

Make type for nodeExtra partial #43

Description

@kirangadhave

Currently the nodeExtra variable is typed as:

    type ProvVisConfig = {
		...
		nodeExtra: Record<S, React.ReactElement | null>;
		...
	}

We should make it partial like so:
nodeExtra: Partial<Record<S, React.ReactElement | null>>;

This stops typescript from complaining that some keys are missing in case we decide that we want to skip extras for certain event types.

e.g. in persist I get this error:
Screenshot 2023-08-03 at 5 58 06 PM

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions