Adds a test to make sure channels are properly closed

tjayrush · tjayrush · commit 84df451e8842 · 2025-10-16T23:27:15.000-04:00
diff --git a/sdk b/sdk
@@ -1 +1 @@
-Subproject commit 5144faf886d58dbb00a01ed0abfeace44668d319
+Subproject commit fd4fbc969a1a5f1b4180d4d1dec0be44854251aa
diff --git a/src/apps/chifra/pkg/output/stream.go b/src/apps/chifra/pkg/output/stream.go
@@ -108,6 +108,8 @@ type fetchDataFunc func(modelChan chan types.Modeler, errorChan chan error)
 func StreamMany(rCtx *RenderCtx, fetchData fetchDataFunc, options OutputOptions) error {
 	if rCtx.ModelChan != nil {
 		fetchData(rCtx.ModelChan, rCtx.ErrorChan)
+		close(rCtx.ModelChan)
+		close(rCtx.ErrorChan)
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,8 @@ type fetchDataFunc func(modelChan chan types.Modeler, errorChan chan error)`
`108`	`108`	`func StreamMany(rCtx *RenderCtx, fetchData fetchDataFunc, options OutputOptions) error {`
`109`	`109`	`if rCtx.ModelChan != nil {`
`110`	`110`	`fetchData(rCtx.ModelChan, rCtx.ErrorChan)`
	`111`	`+ close(rCtx.ModelChan)`
	`112`	`+ close(rCtx.ErrorChan)`
`111`	`113`	`return nil`
`112`	`114`	`}`
`113`	`115`