Skip to content

Commit 7ddcc6d

Browse files
committed
Moved @tryghost/posts-service to core folder
fix https://linear.app/ghost/issue/ENG-2380/posts-service - this commit moves the lib code and tests to the core folder so we can colocate code in one place rather than splitting it out across packages, which increases the cognitive load and overhead
1 parent ec96957 commit 7ddcc6d

File tree

14 files changed

+5
-57
lines changed

14 files changed

+5
-57
lines changed

.docker/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ COPY ghost/mw-vhost/package.json ghost/mw-vhost/package.json
9090
COPY ghost/offers/package.json ghost/offers/package.json
9191
COPY ghost/post-events/package.json ghost/post-events/package.json
9292
COPY ghost/post-revisions/package.json ghost/post-revisions/package.json
93-
COPY ghost/posts-service/package.json ghost/posts-service/package.json
9493
COPY ghost/prometheus-metrics/package.json ghost/prometheus-metrics/package.json
9594
COPY ghost/security/package.json ghost/security/package.json
9695
COPY ghost/tiers/package.json ghost/tiers/package.json

compose.yml

-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ services:
5353
- node_modules_ghost_offers:/home/ghost/ghost/offers/node_modules:delegated
5454
- node_modules_ghost_post-events:/home/ghost/ghost/post-events/node_modules:delegated
5555
- node_modules_ghost_post-revisions:/home/ghost/ghost/post-revisions/node_modules:delegated
56-
- node_modules_ghost_posts-service:/home/ghost/ghost/posts-service/node_modules:delegated
5756
- node_modules_ghost_prometheus-metrics:/home/ghost/ghost/prometheus-metrics/node_modules:delegated
5857
- node_modules_ghost_security:/home/ghost/ghost/security/node_modules:delegated
5958
- node_modules_ghost_tiers:/home/ghost/ghost/tiers/node_modules:delegated
@@ -182,7 +181,6 @@ volumes:
182181
node_modules_ghost_offers: {}
183182
node_modules_ghost_post-events: {}
184183
node_modules_ghost_post-revisions: {}
185-
node_modules_ghost_posts-service: {}
186184
node_modules_ghost_prometheus-metrics: {}
187185
node_modules_ghost_security: {}
188186
node_modules_ghost_tiers: {}

ghost/core/core/server/services/posts/posts-service.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
const {PostsService, PostsExporter} = require('@tryghost/posts-service');
1+
const PostsService = require('./PostsService');
2+
const PostsExporter = require('./PostsExporter');
23
const url = require('../../../server/api/endpoints/utils/serializers/output/utils/url');
34

45
/**

ghost/core/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@
108108
"@tryghost/mw-vhost": "0.0.0",
109109
"@tryghost/nodemailer": "0.3.47",
110110
"@tryghost/nql": "0.12.7",
111+
"@tryghost/post-events": "0.0.0",
111112
"@tryghost/post-revisions": "0.0.0",
112-
"@tryghost/posts-service": "0.0.0",
113113
"@tryghost/pretty-cli": "1.2.46",
114114
"@tryghost/prometheus-metrics": "0.0.0",
115115
"@tryghost/promise": "0.3.14",

ghost/posts-service/test/PostsExporter.test.js renamed to ghost/core/test/unit/server/services/posts/PostsExporter.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const {PostsExporter} = require('../index');
1+
const PostsExporter = require('../../../../../core/server/services/posts/PostsExporter');
22
const assert = require('assert/strict');
33
const {createModelClass, createModel} = require('./utils');
44

ghost/posts-service/test/PostsService.test.js renamed to ghost/core/test/unit/server/services/posts/PostsService.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const {PostsService} = require('../index');
1+
const PostsService = require('../../../../../core/server/services/posts/PostsService');
22
const assert = require('assert/strict');
33
const sinon = require('sinon');
44

ghost/posts-service/.eslintrc.js

-6
This file was deleted.

ghost/posts-service/README.md

-2
This file was deleted.

ghost/posts-service/index.js

-4
This file was deleted.

ghost/posts-service/package.json

-32
This file was deleted.

ghost/posts-service/test/.eslintrc.js

-6
This file was deleted.

0 commit comments

Comments
 (0)