Moved @tryghost/link-replacer to core folder

fix https://linear.app/ghost/issue/ENG-2384/link-replacer

- this commit moves the lib code and tests to the core folder so we can
  colocate code in one place rather than splitting it out across
  packages, which increases the cognitive load and overhead

Author: daniellockyer

.docker/Dockerfile

@@ -79,7 +79,6 @@ COPY ghost/email-service/package.json ghost/email-service/package.json
 COPY ghost/html-to-plaintext/package.json ghost/html-to-plaintext/package.json
 COPY ghost/i18n/package.json ghost/i18n/package.json
 COPY ghost/job-manager/package.json ghost/job-manager/package.json
-COPY ghost/link-replacer/package.json ghost/link-replacer/package.json
 COPY ghost/members-csv/package.json ghost/members-csv/package.json
 COPY ghost/mw-error-handler/package.json ghost/mw-error-handler/package.json
 COPY ghost/mw-vhost/package.json ghost/mw-vhost/package.json

compose.yml

@@ -44,7 +44,6 @@ services:
       - node_modules_ghost_html-to-plaintext:/home/ghost/ghost/html-to-plaintext/node_modules:delegated
       - node_modules_ghost_i18n:/home/ghost/ghost/i18n/node_modules:delegated
       - node_modules_ghost_job-manager:/home/ghost/ghost/job-manager/node_modules:delegated
-      - node_modules_ghost_link-replacer:/home/ghost/ghost/link-replacer/node_modules:delegated
       - node_modules_ghost_members-csv:/home/ghost/ghost/members-csv/node_modules:delegated
       - node_modules_ghost_mw-error-handler:/home/ghost/ghost/mw-error-handler/node_modules:delegated
       - node_modules_ghost_mw-vhost:/home/ghost/ghost/mw-vhost/node_modules:delegated
@@ -190,7 +189,6 @@ volumes:
   node_modules_ghost_html-to-plaintext: {}
   node_modules_ghost_i18n: {}
   node_modules_ghost_job-manager: {}
-  node_modules_ghost_link-replacer: {}
   node_modules_ghost_members-csv: {}
   node_modules_ghost_mw-error-handler: {}
   node_modules_ghost_mw-vhost: {}

ghost/core/core/server/services/email-service/EmailServiceWrapper.js

@@ -34,7 +34,7 @@ class EmailServiceWrapper {
         const lexicalLib = require('../../lib/lexical');
         const urlUtils = require('../../../shared/url-utils');
         const memberAttribution = require('../member-attribution');
-        const linkReplacer = require('@tryghost/link-replacer');
+        const linkReplacer = require('../lib/link-replacer');
         const linkTracking = require('../link-tracking');
         const audienceFeedback = require('../audience-feedback');
         const storageUtils = require('../../adapters/storage/utils');

ghost/link-replacer/lib/link-replacer.js renamed to ghost/core/core/server/services/lib/link-replacer.js

@@ -2,7 +2,7 @@ class LinkReplacer {
     /**
      * Replaces the links in the provided HTML
      * @param {string} html
-     * @param {(url: URL, originalPath: string): Promise<URL|string|false>} replaceLink
+     * @param {(url: URL, originalPath: string) => Promise<URL|string|false>} replaceLink
      * @param {object} options
      * @param {string} [options.base] If you want to replace relative links, this will replace them to an absolute link and call the replaceLink method too
      * @returns {Promise<string>}

ghost/core/core/server/services/member-attribution/OutboundLinkTagger.js

@@ -1,5 +1,5 @@
 const {slugify} = require('@tryghost/string');
-const LinkReplacer = require('@tryghost/link-replacer');
+const LinkReplacer = require('../lib/link-replacer');
 
 const blockedReferrerDomains = [
     // Facebook has some restrictions on the 'ref' attribute (max 15 chars + restricted character set) that breaks links if we add ?ref=longer-string

ghost/core/package.json

@@ -98,7 +98,6 @@
     "@tryghost/kg-lexical-html-renderer": "1.3.5",
     "@tryghost/kg-mobiledoc-html-renderer": "7.1.1",
     "@tryghost/limit-service": "1.2.15",
-    "@tryghost/link-replacer": "0.0.0",
     "@tryghost/logging": "2.4.21",
     "@tryghost/members-csv": "0.0.0",
     "@tryghost/members-offers": "0.0.0",
@@ -147,6 +146,7 @@
     "date-fns": "2.30.0",
     "dompurify": "3.2.5",
     "downsize": "0.0.8",
+    "entities": "4.5.0",
     "express": "4.21.2",
     "express-brute": "1.0.1",
     "express-hbs": "2.5.0",
@@ -164,6 +164,7 @@
     "gscan": "4.48.0",
     "handlebars": "4.7.8",
     "html-to-text": "5.1.1",
+    "html5parser": "2.0.2",
     "human-number": "2.0.4",
     "iconv-lite": "0.6.3",
     "image-size": "1.2.1",

ghost/link-replacer/test/LinkReplacer.test.js renamed to ghost/core/test/unit/server/services/lib/LinkReplacer.test.js

@@ -1,5 +1,5 @@
 const assert = require('assert/strict');
-const linkReplacer = require('../lib/link-replacer');
+const linkReplacer = require('../../../../../core/server/services/lib/link-replacer');
 const html5parser = require('html5parser');
 const sinon = require('sinon');
 
@@ -8,10 +8,6 @@ describe('LinkReplacementService', function () {
         sinon.restore();
     });
 
-    it('exported', function () {
-        assert.equal(require('../index'), linkReplacer);
-    });
-
     describe('replace', function () {
         it('Can replace to URL', async function () {
             const html = '<a href="http://localhost:2368/dir/path">link</a>';

ghost/link-replacer/test/fixtures/example-post.html renamed to ghost/core/test/unit/server/services/lib/fixtures/example-post.html

@@ -2,7 +2,7 @@ const {EmailRenderer} = require('../');
 const assert = require('assert/strict');
 const cheerio = require('cheerio');
 const {createModel, createModelClass} = require('./utils');
-const linkReplacer = require('@tryghost/link-replacer');
+const linkReplacer = require('../../core/core/server/services/lib/link-replacer');
 const sinon = require('sinon');
 const logging = require('@tryghost/logging');
 const {HtmlValidate} = require('html-validate');
@@ -2701,7 +2701,7 @@ describe('Email renderer', function () {
         beforeEach(function () {
             renderedPost = '<p>Lexical Test</p><img class="is-light-background" src="test-dark" /><img class="is-dark-background" src="test-light" />';
             labsEnabled = true; // TODO: odd default because it means we're testing the unused email-customization template
-            
+
             postUrl = 'http://example.com';
             customSettings = {
                 locale: 'fr',

ghost/email-service/test/email-renderer.test.js

@@ -4270,25 +4270,6 @@
   resolved "https://registry.yarnpkg.com/@popperjs/core/-/core-2.11.8.tgz#6b79032e760a0899cd4204710beede972a3a185f"
   integrity sha512-P1st0aksCrn9sGZhp8GMYwBnQsbvAWsZAX44oXNNvLHGqAOcoVxmjZiohstwQ7SqKnbR47akdNi+uleWD8+g6A==
 
-"@probe.gl/[email protected]":
-  version "4.1.0"
-  resolved "https://registry.yarnpkg.com/@probe.gl/bench/-/bench-4.1.0.tgz#2a0d1aa58f21874fdfb9cf49b3268cc0c169c773"
-  integrity sha512-4Jb1B1NHXDayWGzz4oHs3IgymdBq2AVzMUlcE428lELFqGP7nnRMqeGR/PmwElCqvYLJE39Av4QK8E64lUw/cA==
-  dependencies:
-    "@probe.gl/log" "4.1.0"
-
-"@probe.gl/[email protected]":
-  version "4.1.0"
-  resolved "https://registry.yarnpkg.com/@probe.gl/env/-/env-4.1.0.tgz#c2af9030a8711f2d98590850aa47a5f58feef211"
-  integrity sha512-5ac2Jm2K72VCs4eSMsM7ykVRrV47w32xOGMvcgqn8vQdEMF9PRXyBGYEV9YbqRKWNKpNKmQJVi4AHM/fkCxs9w==
-
-"@probe.gl/[email protected]":
-  version "4.1.0"
-  resolved "https://registry.yarnpkg.com/@probe.gl/log/-/log-4.1.0.tgz#b5501f96e3aa7f04c75a9800431314d46911cb98"
-  integrity sha512-r4gRReNY6f+OZEMgfWEXrAE2qJEt8rX0HsDJQXUBMoc+5H47bdB7f/5HBHAmapK8UydwPKL9wCDoS22rJ0yq7Q==
-  dependencies:
-    "@probe.gl/env" "4.1.0"
-
 "@radix-ui/[email protected]":
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/@radix-ui/number/-/number-1.0.1.tgz#644161a3557f46ed38a042acf4a770e826021674"