Skip to content

Commit bbc9807

Browse files
committed
Moved @tryghost/importer-handler-content-files to core folder
fix https://linear.app/ghost/issue/ENG-2113/importer-handler-content-files - this commit moves the lib code and tests to the core folder so we can colocate code in one place rather than splitting it out across packages, which increases the cognitive load and overhead
1 parent ba90631 commit bbc9807

File tree

11 files changed

+2
-68
lines changed

11 files changed

+2
-68
lines changed

.docker/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ COPY ghost/express-dynamic-redirects/package.json ghost/express-dynamic-redirect
8989
COPY ghost/ghost/package.json ghost/ghost/package.json
9090
COPY ghost/html-to-plaintext/package.json ghost/html-to-plaintext/package.json
9191
COPY ghost/i18n/package.json ghost/i18n/package.json
92-
COPY ghost/importer-handler-content-files/package.json ghost/importer-handler-content-files/package.json
9392
COPY ghost/in-memory-repository/package.json ghost/in-memory-repository/package.json
9493
COPY ghost/job-manager/package.json ghost/job-manager/package.json
9594
COPY ghost/link-redirects/package.json ghost/link-redirects/package.json

compose.yml

-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ services:
5353
- node_modules_ghost_ghost:/home/ghost/ghost/ghost/node_modules:delegated
5454
- node_modules_ghost_html-to-plaintext:/home/ghost/ghost/html-to-plaintext/node_modules:delegated
5555
- node_modules_ghost_i18n:/home/ghost/ghost/i18n/node_modules:delegated
56-
- node_modules_ghost_importer-handler-content-files:/home/ghost/ghost/importer-handler-content-files/node_modules:delegated
5756
- node_modules_ghost_in-memory-repository:/home/ghost/ghost/in-memory-repository/node_modules:delegated
5857
- node_modules_ghost_job-manager:/home/ghost/ghost/job-manager/node_modules:delegated
5958
- node_modules_ghost_link-redirects:/home/ghost/ghost/link-redirects/node_modules:delegated
@@ -196,7 +195,6 @@ volumes:
196195
node_modules_ghost_ghost: {}
197196
node_modules_ghost_html-to-plaintext: {}
198197
node_modules_ghost_i18n: {}
199-
node_modules_ghost_importer-handler-content-files: {}
200198
node_modules_ghost_in-memory-repository: {}
201199
node_modules_ghost_job-manager: {}
202200
node_modules_ghost_link-redirects: {}

ghost/core/core/server/data/importer/import-manager.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const debug = require('@tryghost/debug')('import-manager');
1111
const logging = require('@tryghost/logging');
1212
const errors = require('@tryghost/errors');
1313
const ImageHandler = require('./handlers/image');
14-
const ImporterContentFileHandler = require('@tryghost/importer-handler-content-files');
14+
const ImporterContentFileHandler = require('./handlers/ImporterContentFileHandler');
1515
const RevueHandler = require('./handlers/revue');
1616
const JSONHandler = require('./handlers/json');
1717
const MarkdownHandler = require('./handlers/markdown');

ghost/core/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@
9393
"@tryghost/http-cache-utils": "0.1.17",
9494
"@tryghost/i18n": "0.0.0",
9595
"@tryghost/image-transform": "1.3.0",
96-
"@tryghost/importer-handler-content-files": "0.0.0",
9796
"@tryghost/in-memory-repository": "0.0.0",
9897
"@tryghost/job-manager": "0.0.0",
9998
"@tryghost/kg-card-factory": "5.1.0",

ghost/importer-handler-content-files/test/ImporterContentFileHandler.test.js renamed to ghost/core/test/unit/server/data/importer/handlers/ImporterContentFileHandler.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const assert = require('assert/strict');
2-
const ImporterContentFileHandler = require('../index');
2+
const ImporterContentFileHandler = require('../../../../../../core/server/data/importer/handlers/ImporterContentFileHandler');
33

44
describe('ImporterContentFileHandler', function () {
55
it('creates an instance', function () {

ghost/importer-handler-content-files/.eslintrc.js

-6
This file was deleted.

ghost/importer-handler-content-files/README.md

-23
This file was deleted.

ghost/importer-handler-content-files/index.js

-1
This file was deleted.

ghost/importer-handler-content-files/package.json

-26
This file was deleted.

ghost/importer-handler-content-files/test/.eslintrc.js

-6
This file was deleted.

0 commit comments

Comments
 (0)