Skip to content

Commit dbfa363

Browse files
authored
Removed the unused rewire devDependency (#28673)
no ref - Removes the `rewire` devDependency from `ghost/core` now that every test that used it has been migrated to sinon object-boundary stubbing. - Drops a now-stale comment in `model-posts.test.js` that referenced rewire.
1 parent af5c56c commit dbfa363

3 files changed

Lines changed: 0 additions & 17 deletions

File tree

ghost/core/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,6 @@
300300
"postcss": "catalog:",
301301
"postcss-cli": "11.0.1",
302302
"qs": "6.15.2",
303-
"rewire": "9.0.1",
304303
"sinon": "catalog:",
305304
"supertest": "catalog:",
306305
"tmp": "0.2.6",

ghost/core/test/legacy/models/model-posts.test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ const markdownToMobiledoc = testUtils.DataGenerator.markdownToMobiledoc;
2121
* IMPORTANT:
2222
* - do not spy the events unit, because when we only spy, all listeners get the event
2323
* - this can cause unexpected behavior as the listeners execute code
24-
* - using rewire is not possible, because each model self registers it's model registry in bookshelf
25-
* - rewire would add 1 registry, a file who requires the models, tries to register the model another time
2624
*/
2725
describe('Post Model', function () {
2826
let eventsTriggered = {};

pnpm-lock.yaml

Lines changed: 0 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)