Skip to content

Commit de9093b

Browse files
committed
Moved @tryghost/mentions-email-report to Ghost core
fix https://linear.app/ghost/issue/ENG-2069/mentions-email-report - this commit migrates the code and test for the mentions email report service into Ghost core so we can keep all related code together and reduce overhead - as a result of this change, we can remove the package and associated references
1 parent ca7e622 commit de9093b

File tree

10 files changed

+4
-67
lines changed

10 files changed

+4
-67
lines changed

compose.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ services:
7979
- node_modules_ghost_members-csv:/home/ghost/ghost/members-csv/node_modules:delegated
8080
- node_modules_ghost_members-importer:/home/ghost/ghost/members-importer/node_modules:delegated
8181
- node_modules_ghost_members-ssr:/home/ghost/ghost/members-ssr/node_modules:delegated
82-
- node_modules_ghost_mentions-email-report:/home/ghost/ghost/mentions-email-report/node_modules:delegated
8382
- node_modules_ghost_metrics-server:/home/ghost/ghost/metrics-server/node_modules:delegated
8483
- node_modules_ghost_milestones:/home/ghost/ghost/milestones/node_modules:delegated
8584
- node_modules_ghost_minifier:/home/ghost/ghost/minifier/node_modules:delegated
@@ -251,7 +250,6 @@ volumes:
251250
node_modules_ghost_members-csv: {}
252251
node_modules_ghost_members-importer: {}
253252
node_modules_ghost_members-ssr: {}
254-
node_modules_ghost_mentions-email-report: {}
255253
node_modules_ghost_metrics-server: {}
256254
node_modules_ghost_milestones: {}
257255
node_modules_ghost_minifier: {}

ghost/core/core/server/services/mentions-email-report/service.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
const MentionEmailReportJob = require('@tryghost/mentions-email-report');
1+
const MentionEmailReportJob = require('./MentionEmailReportJob');
22

33
/**
4-
* @typedef {import('@tryghost/mentions-email-report/lib/mentions-email-report').MentionReport} MentionReport
5-
* @typedef {import('@tryghost/mentions-email-report/lib/mentions-email-report').MentionReportRecipient} MentionReportRecipient
4+
* @typedef {MentionEmailReportJob.MentionReport} MentionReport
5+
* @typedef {MentionEmailReportJob.MentionReportRecipient} MentionReportRecipient
66
*/
77

88
let initialised = false;

ghost/core/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@
126126
"@tryghost/members-offers": "0.0.0",
127127
"@tryghost/members-ssr": "0.0.0",
128128
"@tryghost/members-stripe-service": "0.0.0",
129-
"@tryghost/mentions-email-report": "0.0.0",
130129
"@tryghost/metrics": "1.0.37",
131130
"@tryghost/milestones": "0.0.0",
132131
"@tryghost/minifier": "0.0.0",

ghost/mentions-email-report/test/hello.test.js renamed to ghost/core/test/unit/server/services/mentions-email-report/mention-email-report-job.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const sinon = require('sinon');
2-
const MentionEmailReportJob = require('../');
2+
const MentionEmailReportJob = require('../../../../../core/server/services/mentions-email-report/MentionEmailReportJob');
33

44
class MockMentionReportRecipientRepository {
55
#recipients = [{

ghost/mentions-email-report/.eslintrc.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

ghost/mentions-email-report/README.md

Lines changed: 0 additions & 21 deletions
This file was deleted.

ghost/mentions-email-report/index.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

ghost/mentions-email-report/package.json

Lines changed: 0 additions & 26 deletions
This file was deleted.

ghost/mentions-email-report/test/.eslintrc.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)