Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webp handling and storage adapters #21146

Open
1 task done
elijahsgh opened this issue Sep 27, 2024 · 0 comments
Open
1 task done

webp handling and storage adapters #21146

elijahsgh opened this issue Sep 27, 2024 · 0 comments
Labels
needs:triage [triage] this needs to be triaged by the Ghost team

Comments

@elijahsgh
Copy link

Issue Summary

The newest templates expect to be able to serve images via format="webp"
This means the newest templates will NOT work with any sort of storage adapters other than local. To make matters worse, the local storage adapter seems to label everything as a .jpg when they are .webp (this was, at some point, for backward compatibility I believe).

The problem here seems to be that ghost only generates the webp images on request. Instead this should be moved to generating the actual webp (with .webp extension) during upload. From what I understand, this means the storage adapter would automatically write the new images at the request of Ghost.

The .jpg naming, I believe, should also be considered a bug since this is very odd and unexpected operation.

I am labeling this as a bug and not a feature request because at this time Ghost simply does not work correctly with any new template including templates like Source. All of your uploaded images, when using a storage adapter, will not be found.

Steps to Reproduce

  1. Add a storage adapter
  2. Upload an image
  3. Use a recent template
  4. Your images are broken

Ghost Version

5.0x

Node.js Version

any

How did you install Ghost?

ghost install

Database type

MySQL 8

Browser & OS version

Any

Relevant log / error output

No errors - simply 404s for the images.

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage [triage] this needs to be triaged by the Ghost team
Projects
None yet
Development

No branches or pull requests

1 participant