Fix/issue #35 (#37)

* Create npm-publish.yml (#27)

* fix: fixed a bug when margin are provided docx is not generated properly

* Feature/contributors update (#26)

* feat: add contributors

* fix: cleanup readme

* feat: add banner and updated package.json

* chore: fixes and update .gitignore

* chore: readme styling

* chore: readme refactor styling

* chore: add AmitSharma512 as a contributor

---------

Co-authored-by: Nicolas <[email protected]>
Co-authored-by: nicolasiscoding <[email protected]>

Author: AmitSharma512

.github/workflows/npm-publish.yml

@@ -28,7 +28,7 @@ jobs:
           node-version: 18
           registry-url: https://registry.npmjs.org/
       - run: npm ci
-      - run: npm run build 
+      - run: npm run build
       - run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{secrets.npm_token}}

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@turbodocx/html-to-docx",
-  "version": "1.9.4",
+  "version": "1.9.3",
   "description": "HTML to DOCX converter",
   "keywords": [
     "html",
@@ -41,7 +41,8 @@
     "zedtux <[email protected]>",
     "hlerebours",
     "hakjeri",
-    "tasola"
+    "tasola",
+    "AmitSharma512"
   ],
   "license": "MIT",
   "bugs": {

src/docx-document.js

@@ -124,14 +124,18 @@ class DocxDocument {
     this.width = isPortraitOrientation ? width : height;
     this.height = isPortraitOrientation ? height : width;
 
-    const marginsObject = properties.margins;
-    this.margins =
-      // eslint-disable-next-line no-nested-ternary
-      marginsObject && Object.keys(marginsObject).length
-        ? marginsObject
-        : isPortraitOrientation
-        ? portraitMargins
-        : landscapeMargins;
+    const defaultMargins = isPortraitOrientation ? portraitMargins : landscapeMargins;
+    const marginsObject = properties.margins || {};
+
+    this.margins = {
+      top: marginsObject.top !== undefined ? marginsObject.top : defaultMargins.top,
+      right: marginsObject.right !== undefined ? marginsObject.right : defaultMargins.right,
+      bottom: marginsObject.bottom !== undefined ? marginsObject.bottom : defaultMargins.bottom,
+      left: marginsObject.left !== undefined ? marginsObject.left : defaultMargins.left,
+      header: marginsObject.header !== undefined ? marginsObject.header : defaultMargins.header,
+      footer: marginsObject.footer !== undefined ? marginsObject.footer : defaultMargins.footer,
+      gutter: marginsObject.gutter !== undefined ? marginsObject.gutter : defaultMargins.gutter,
+    };
 
     this.availableDocumentSpace = this.width - this.margins.left - this.margins.right;
     this.title = properties.title || '';