Skip to content

Commit 851256d

Browse files
committed
Try doing universal builds as separate commands
1 parent b65cd8e commit 851256d

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ jobs:
5858
run: npm run webpack:prod
5959
- name: Package
6060
run: |
61-
node release-automation/build.mjs --mac --mac-legacy-11 --universal
61+
# Need to run the universal builds as separate commands or it breaks when @electron/universal
62+
# diffs the ASARs and finds spurious differences. Not clear why.
63+
node release-automation/build.mjs --mac --universal --production
64+
node release-automation/build.mjs --mac-legacy-11 --universal --production
6265
node release-automation/build.mjs --mac-legacy-10.13-10.14 --mac-legacy-10.15 --x64
6366
- name: Print file tree
6467
run: node scripts/print-file-tree.mjs dist

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,10 @@ jobs:
7676
python3 -c "import os; open(os.getenv('APPLE_API_KEY_NAME'), 'w').write(os.getenv('APPLE_API_KEY_DATA'))" >/dev/null 2>&1
7777
# @electron/notaraize documentation says key should be an absolute path
7878
export APPLE_API_KEY="$(pwd)/$APPLE_API_KEY_NAME"
79-
node release-automation/build.mjs --mac --mac-legacy-11 --universal --production
79+
# Need to run the universal builds as separate commands or it breaks when @electron/universal
80+
# diffs the ASARs and finds spurious differences. Not clear why.
81+
node release-automation/build.mjs --mac --universal --production
82+
node release-automation/build.mjs --mac-legacy-11 --universal --production
8083
# These macOS versions never ran on an Apple Silicon device, so only need x64
8184
node release-automation/build.mjs --mac-legacy-10.13-10.14 --mac-legacy-10.15 --x64 --production
8285
# for safety

0 commit comments

Comments
 (0)