wkwebview: disable beeping noise on key press

GarboMuffin · GarboMuffin · commit 5010ae49228e · 2025-01-18T11:56:47.000-06:00
Fixes #937
diff --git a/wkwebview/WebView/ViewController.swift b/wkwebview/WebView/ViewController.swift
@@ -136,4 +136,8 @@ class ViewController: NSViewController, WKNavigationDelegate, WKUIDelegate, WKSc
 //        Implements window.close()
         self.view.window?.close();
     }
+
+    override func keyDown(with event: NSEvent) {
+//        Don't call super.keyDown so that it won't play the beeping noise.
+    }
 }
diff --git a/wkwebview/WebView/index.html b/wkwebview/WebView/index.html
@@ -5,15 +5,25 @@
         <meta charset="utf-8">
         <meta name="viewport" content="width=device-width, initial-scale=1">
         <meta name="color-scheme" content="light dark">
+        <style>
+            textarea {
+                width: 100%;
+                box-sizing: border-box;
+                min-height: 100px;
+            }
+        </style>
     </head>
     <body>
         <h1>It works!</h1>
+
         <button onclick="testDownload()">Test file download</button>
         <button onclick="testCamera()">Test camera</button>
         <button onclick="testMicrophone()">Test microphone</button>
         <button onclick="window.close()">window.close()</button>
         <button onclick="testLocalFetchFromMain()">Test local fetch from main</button>
         <button onclick="testLocalFetchFromBlobWorker()">Test local fetch from blob: worker</button>
+        <button onclick="testTextInput()">Test text input</button>
+
         <script>
             const testDownload = async () => {
                 const blob = new Blob([
@@ -80,6 +90,22 @@ <h1>It works!</h1>
                     document.body.appendChild(el);
                 });
             };
+
+            const testTextInput = () => {
+                const textarea = document.createElement("textarea");
+                textarea.placeholder = "Type here...";
+                document.body.appendChild(textarea);
+                document.addEventListener("keydown", (e) => {
+                    if (e.target !== textarea) {
+                        textarea.value = `keydown ${e.key}\n${textarea.value}`;
+                    }
+                });
+                document.addEventListener("keyup", (e) => {
+                    if (e.target !== textarea) {
+                        textarea.value = `keyup ${e.key}\n${textarea.value}`;
+                    }
+                });
+            };
         </script>
     </body>
 </html>

Original file line number	Diff line number	Diff line change
`@@ -136,4 +136,8 @@ class ViewController: NSViewController, WKNavigationDelegate, WKUIDelegate, WKSc`
`136`	`136`	`// Implements window.close()`
`137`	`137`	`self.view.window?.close();`
`138`	`138`	`}`
	`139`	`+`
	`140`	`+ override func keyDown(with event: NSEvent) {`
	`141`	`+// Don't call super.keyDown so that it won't play the beeping noise.`
	`142`	`+ }`
`139`	`143`	`}`