Print threadid before failure

Author: penelopeysm

src/threadsafe.jl

@@ -22,11 +22,11 @@ transformation(vi::ThreadSafeVarInfo) = transformation(vi.varinfo)
 # Instead of updating the log probability of the underlying variables we
 # just update the array of log probabilities.
 function acclogp!!(vi::ThreadSafeVarInfo, logp)
-    vi.logps[Threads.threadid()] += logp
+    vi.logps[1] += logp
     return vi
 end
 function acclogp!!(vi::ThreadSafeVarInfoWithRef, logp)
-    vi.logps[Threads.threadid()][] += logp
+    vi.logps[1][] += logp
     return vi
 end
 

test/runtests.jl

@@ -54,63 +54,63 @@ include("test_util.jl")
         if AQUA
             include("Aqua.jl")
         end
-        include("utils.jl")
-        include("compiler.jl")
-        include("varnamedvector.jl")
-        include("varinfo.jl")
-        include("simple_varinfo.jl")
-        include("model.jl")
-        include("sampler.jl")
-        include("independence.jl")
-        include("distribution_wrappers.jl")
-        include("logdensityfunction.jl")
-        include("linking.jl")
-        include("serialization.jl")
-        include("pointwise_logdensities.jl")
-        include("lkj.jl")
-        include("contexts.jl")
-        include("context_implementations.jl")
+        # include("utils.jl")
+        # include("compiler.jl")
+        # include("varnamedvector.jl")
+        # include("varinfo.jl")
+        # include("simple_varinfo.jl")
+        # include("model.jl")
+        # include("sampler.jl")
+        # include("independence.jl")
+        # include("distribution_wrappers.jl")
+        # include("logdensityfunction.jl")
+        # include("linking.jl")
+        # include("serialization.jl")
+        # include("pointwise_logdensities.jl")
+        # include("lkj.jl")
+        # include("contexts.jl")
+        # include("context_implementations.jl")
         include("threadsafe.jl")
-        include("debug_utils.jl")
-        include("deprecated.jl")
-        include("submodels.jl")
+        # include("debug_utils.jl")
+        # include("deprecated.jl")
+        # include("submodels.jl")
     end
 
     if GROUP == "All" || GROUP == "Group2"
-        @testset "compat" begin
-            include(joinpath("compat", "ad.jl"))
-        end
-        @testset "extensions" begin
-            include("ext/DynamicPPLMCMCChainsExt.jl")
-            include("ext/DynamicPPLJETExt.jl")
-        end
-        @testset "ad" begin
-            include("ext/DynamicPPLForwardDiffExt.jl")
-            if !IS_PRERELEASE
-                include("ext/DynamicPPLMooncakeExt.jl")
-            end
-            include("ad.jl")
-        end
-        @testset "prob and logprob macro" begin
-            @test_throws ErrorException prob"..."
-            @test_throws ErrorException logprob"..."
-        end
-        if !IS_PRERELEASE
-            # Don't run doctests on prerelease as error messages etc. may vary
-            @testset "doctests" begin
-                DocMeta.setdocmeta!(
-                    DynamicPPL,
-                    :DocTestSetup,
-                    :(using DynamicPPL, Distributions);
-                    recursive=true,
-                )
-                doctestfilters = [
-                    # Ignore the source of a warning in the doctest output, since this is dependent on host.
-                    # This is a line that starts with "└ @ " and ends with the line number.
-                    r"└ @ .+:[0-9]+",
-                ]
-                doctest(DynamicPPL; manual=false, doctestfilters=doctestfilters)
-            end
-        end
+        # @testset "compat" begin
+        #     include(joinpath("compat", "ad.jl"))
+        # end
+        # @testset "extensions" begin
+        #     include("ext/DynamicPPLMCMCChainsExt.jl")
+        #     include("ext/DynamicPPLJETExt.jl")
+        # end
+        # @testset "ad" begin
+        #     include("ext/DynamicPPLForwardDiffExt.jl")
+        #     if !IS_PRERELEASE
+        #         include("ext/DynamicPPLMooncakeExt.jl")
+        #     end
+        #     include("ad.jl")
+        # end
+        # @testset "prob and logprob macro" begin
+        #     @test_throws ErrorException prob"..."
+        #     @test_throws ErrorException logprob"..."
+        # end
+        # if !IS_PRERELEASE
+        #     # Don't run doctests on prerelease as error messages etc. may vary
+        #     @testset "doctests" begin
+        #         DocMeta.setdocmeta!(
+        #             DynamicPPL,
+        #             :DocTestSetup,
+        #             :(using DynamicPPL, Distributions);
+        #             recursive=true,
+        #         )
+        #         doctestfilters = [
+        #             # Ignore the source of a warning in the doctest output, since this is dependent on host.
+        #             # This is a line that starts with "└ @ " and ends with the line number.
+        #             r"└ @ .+:[0-9]+",
+        #         ]
+        #         doctest(DynamicPPL; manual=false, doctestfilters=doctestfilters)
+        #     end
+        # end
     end
 end

test/threadsafe.jl

@@ -42,6 +42,7 @@
             global vi_ = __varinfo__
             x[1] ~ Normal(0, 1)
             Threads.@threads for i in 2:length(x)
+                @show Threads.threadid()
                 x[i] ~ Normal(x[i - 1], 1)
             end
         end
@@ -60,6 +61,7 @@
         @time wthreads(x)(vi)
 
         # Ensure that we use `ThreadSafeVarInfo` to handle multithreaded observe statements.
+        @info "Threads.threadid() = $(Threads.threadid())"
         DynamicPPL.evaluate_threadsafe!!(
             wthreads(x),
             vi,