Fix display bug

Previously, using the `posts_per_page` param didn't actually restrict
the number of FAQ's returned. This fixes #20 by removing the `nopaging`
param

Author: j-gardner

includes/class-arconix-faq-admin.php

@@ -35,7 +35,7 @@ function __construct() {
      * @version 1.4.0
      */
     function constants() {
-        define( 'ACFAQ_VERSION',          '1.4.2' );
+        define( 'ACFAQ_VERSION',          '1.4.3' );
         define( 'ACFAQ_URL',              trailingslashit( plugin_dir_url( __FILE__ ) ) );
         define( 'ACFAQ_DIR',              trailingslashit( plugin_dir_path( __FILE__ ) ) );
     }
@@ -136,7 +136,6 @@ function defaults() {
                 'order'             => 'ASC',
                 'orderby'           => 'title',
                 'posts_per_page'    => -1,
-                'nopaging'          => true,
                 'group'             => '',
             )
         );
@@ -209,7 +208,6 @@ function faq_shortcode( $atts, $content = null ) {
         if( isset( $atts['showposts'] ) ) {
             if( $atts['showposts'] != "all" and $atts['showposts'] > 0 ) {
                 $atts['posts_per_page'] = $atts['showposts'];
-                $atts['nopaging'] = false;
             }
         }
 

includes/class-arconix-faq.php

@@ -16,15 +16,14 @@ function __construct() { }
      * @param  boolean $echo Echo or Return the data
      * @return mixed   FAQ information for display
      * @since 1.2.0
-     * @version 1.4.2
+     * @version 1.4.3
      */
     function loop( $args, $echo = false ) {
 
         $defaults = array(
                 'order'             => 'ASC',
                 'orderby'           => 'title',
                 'posts_per_page'    => -1,
-                'nopaging'          => true,
                 'group'             => '',
         );
 
@@ -52,7 +51,6 @@ function loop( $args, $echo = false ) {
                     'order'             => $args['order'],
                     'orderby'           => $args['orderby'],
                     'posts_per_page'    => $args['posts_per_page'],
-                    'nopaging'          => $args['nopaging'],
                     'tax_query'         => array(
                         array(
                             'taxonomy'      => 'group',
@@ -118,8 +116,7 @@ function loop( $args, $echo = false ) {
                 'post_type'         => 'faq',
                 'order'             => $args['order'],
                 'orderby'           => $args['orderby'],
-                'posts_per_page'    => $args['posts_per_page'],
-                'nopaging'          => $args['nopaging'],
+                'posts_per_page'    => $args['posts_per_page']
             ) );
 
 

readme.txt

@@ -4,7 +4,7 @@ Donate link: http://arcnx.co/acfdonation
 Tags: arconix, faq, toggle
 Requires at least: 3.8
 Tested up to: 3.9
-Stable tag: 1.4.2
+Stable tag: 1.4.3
 
 Arconix FAQ provides an easy way to add FAQ items to your website.
 
@@ -61,6 +61,9 @@ That's fantastic! Feel free to submit a pull request over at [Github](http://arc
 3. Grouping and Toggling display
 
 == Changelog ==
+= 1.4.3 =
+Fixes a parameter bug that prevented users from restricting the number of FAQ's returned for display
+
 = 1.4.2 =
 Fix undefined variable bug that would show up when no FAQ groups were used