[TT-16977] fix: prevent dep-guard from skipping downstream jobs on push#972
[TT-16977] fix: prevent dep-guard from skipping downstream jobs on push#972buger merged 1 commit intorelease-1.14from
Conversation
Add !cancelled() + result checks to all downstream jobs that depend on goreleaser to prevent GitHub Actions transitive skip propagation when dep-guard is skipped on push/tag events. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This pull request fixes an issue in the The fix involves updating the conditional logic ( Additionally, the Files Changed Analysis
Architecture & Impact Assessment
Here is a diagram illustrating the job dependency and the logic change: graph TD
subgraph on_pull_request ["on: pull_request"]
A[dep-guard] --> B[goreleaser]
end
subgraph on_push ["on: push"]
A_skipped((dep-guard))
style A_skipped fill:#f9f,stroke:#333,stroke-width:2px
A_skipped -.-> B_skipped((goreleaser))
style B_skipped fill:#f9f,stroke:#333,stroke-width:2px
end
B --> C[test-controller-api]
B --> D[api-tests]
B --> E[sbom]
C --> D
classDef skipped fill:#f9f,stroke:#333,stroke-width:2px
subgraph before_change ["Before Change (on push)"]
direction LR
A_skipped_before((dep-guard)) --> B_skipped_before((goreleaser)) --> C_skipped((test-controller-api))
B_skipped_before --> D_skipped((api-tests))
B_skipped_before --> E_skipped((sbom))
class A_skipped_before,B_skipped_before,C_skipped,D_skipped,E_skipped skipped
end
subgraph after_change ["After Change (on push)"]
direction LR
A_skipped_after((dep-guard))
B_runs[goreleaser]
C_runs[test-controller-api]
D_runs[api-tests]
E_runs[sbom]
A_skipped_after --|if: github.event_name == 'pull_request'|-->x B_runs
B_runs --|if: needs.goreleaser.result == 'success'|--> C_runs
B_runs --|if: ...|--> D_runs
B_runs --|if: ...|--> E_runs
class A_skipped_after skipped
end
Scope Discovery & Context ExpansionThis change is confined to the GitHub Actions workflow configuration. While it doesn't alter application code, it has a significant impact on the development and release process by ensuring that CI checks that were previously being skipped on push events will now run. This improves the integrity of the release process by guaranteeing that tests and builds are consistently executed before a release. Metadata
Powered by Visor from Probelabs Last updated: 2026-04-17T12:01:21.417Z | Triggered by: pr_opened | Commit: 561024f 💡 TIP: You can chat with Visor using |
✅ Security Check PassedNo security issues found – changes LGTM. ✅ Security Check PassedNo security issues found – changes LGTM. \n\n \n\n✅ Performance Check PassedNo performance issues found – changes LGTM. Quality Issues (1)
Powered by Visor from Probelabs Last updated: 2026-04-17T12:01:07.018Z | Triggered by: pr_opened | Commit: 561024f 💡 TIP: You can chat with Visor using |
|
probelabs
Bot
changed the title
🚨 Jira Linter FailedCommit: The Jira linter failed to validate your PR. Please check the error details below: 🔍 Click to view error detailsNext Steps
This comment will be automatically deleted once the linter passes. |
1 participant
Summary
!cancelled()+ result checks to all downstream jobs that depend on goreleaser (test-controller-api,api-tests,test-controller-distros,upgrade-deb,upgrade-rpm,sbom) to prevent GitHub Actions transitive skip propagation when dep-guard is skipped on push/tag eventsdep-guardtoaggregator-ci-testneeds for complete status aggregationTest plan
🤖 Generated with Claude Code